-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Enable async testing in CI #121857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Enable async testing in CI #121857
Conversation
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables async testing in the CI pipeline for native AOT builds following the merge of prerequisite work in #121814. The changes selectively enable the async test suite for NativeAOT while keeping it disabled for other runtime flavors.
- Modified build configuration to allow async tests to run for NativeAOT
- Added async tests to the Checked configuration NativeAOT CI pipeline
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tests/async/Directory.Build.targets | Updated DisableProjectBuild conditions to enable async tests specifically for NativeAOT (when TestBuildMode is 'nativeaot') while keeping them disabled for mono, wasm, and default CoreCLR builds |
| eng/pipelines/runtime.yml | Added "async;" to the test build arguments for the NativeAOT Checked configuration to include async tests in the CI test run |
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@MichalStrehovsky, can we add a few representative runtime-async cases somewhere in smoketest as well? |
We have been slowly moving away from adding AOT-specific testing for things that are not AOT specific. Adding a super basic test would be fine I guess (somewhere under SmokeTests/UnitTests) but at this point where only few architectures work it's extra hassle because we need to also duplicate (and keep up to date) the per-platform disabling. |
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Actually, that’s exactly my interest: being able to see how well the community platforms are holding up. Smoketest lowers the infrastructure overhead enough to make that feasible. Running the full test suite is still blocked (#115622 (comment)), so we’ve been using hacky workflows; building only the smoke tests and running them on-device and in QEMU VMs. |
You could instead run the subset specified at That's the "important subset" that we want to run on all PRs. It covers the important things that are not covered in SmokeTests and it's still cheaper to run than all of pri0 tests. |
|
Claude Sonnet 4.5 generated this main...am11:runtime:chore/smoketess-runtime-async, if we could get something like this in smoketests, that would be great. :)
Thanks, I’ll give them a try on linux-riscv64 once the infra is sorted out. At the moment, test builds/runs on community platforms are still rough due to infra issues. |
With #121814 merged we should be able to start running these in the CI for native AOT.
Cc @dotnet/ilc-contrib