Fix RegexParser to ignore vertical tabs with RegexOptions.IgnorePatternWhitespace #120625
+8
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Regex parser to ignore vertical tabs in pattern with RegexOptions.IgnorePatternWhitespace
Plan:
\v
, 0xB) is not ignored with IgnorePatternWhitespaceChanges Made:
\v
to s_metachars SearchValuesif (!PlatformDetection.IsNetFramework)
to prevent failures on .NET FrameworkTest Results:
✅ FunctionalTests: 29,291 tests passed, 0 failures
✅ UnitTests: 1,005 tests passed, 0 failures
✅ New test case: Verified passing across all regex engines (Interpreter, Compiled, NonBacktracking, SourceGenerated) on .NET Core
Technical Details:
Original prompt
Fixes #73206
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.