-
Notifications
You must be signed in to change notification settings - Fork 5k
Try to improve List enumerator perf #116150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
stephentoub
wants to merge
2
commits into
dotnet:main
Choose a base branch
from
stephentoub:optlistenum
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging subscribers to this area: @dotnet/area-system-collections |
@EgorBot -arm -amd -intel using BenchmarkDotNet.Attributes;
using BenchmarkDotNet.Running;
BenchmarkSwitcher.FromAssembly(typeof(Bench).Assembly).Run(args);
[MemoryDiagnoser(false)]
public class Bench
{
[Benchmark]
[ArgumentsSource(nameof(GetLists))]
public int SumList(List<int> list)
{
int sum = 0;
foreach (int item in list)
{
sum += item;
}
return sum;
}
[Benchmark]
[ArgumentsSource(nameof(GetLists))]
public int SumEnumerable(IEnumerable<int> list)
{
int sum = 0;
foreach (int item in list)
{
sum += item;
}
return sum;
}
public static IEnumerable<List<int>> GetLists() =>
from count in new int[] { 1, 10, 1_000 }
select Enumerable.Range(0, count).ToList();
} |
@EgorBot -arm -amd -intel using BenchmarkDotNet.Attributes;
using BenchmarkDotNet.Running;
using System.Runtime.CompilerServices;
BenchmarkSwitcher.FromAssembly(typeof(Bench).Assembly).Run(args);
[DisassemblyDiagnoser]
[MemoryDiagnoser(false)]
public class Bench
{
[Benchmark]
[ArgumentsSource(nameof(GetLists))]
public int SumList(List<string> list)
{
int sum = 0;
foreach (var item in list)
{
sum += Process(item);
}
return sum;
}
[Benchmark]
[ArgumentsSource(nameof(GetLists))]
public int SumEnumerable(IEnumerable<string> list)
{
int sum = 0;
foreach (var item in list)
{
sum += Process(item);
}
return sum;
}
[MethodImpl(MethodImplOptions.NoInlining)]
private static int Process(string item) => item.Length;
public static IEnumerable<List<string>> GetLists() =>
from count in new int[] { 1, 10, 1_000 }
select Enumerable.Range(0, count).Select(i => i.ToString()).ToList();
} |
src/libraries/System.Private.CoreLib/src/System/Collections/Generic/List.cs
Outdated
Show resolved
Hide resolved
@EgorBot -arm -amd -intel using BenchmarkDotNet.Attributes;
using BenchmarkDotNet.Running;
BenchmarkSwitcher.FromAssembly(typeof(Bench).Assembly).Run(args);
[MemoryDiagnoser(false)]
public class Bench
{
[Benchmark]
[ArgumentsSource(nameof(GetLists))]
public int SumList(List<int> list)
{
int sum = 0;
foreach (int item in list)
{
sum += item;
}
return sum;
}
[Benchmark]
[ArgumentsSource(nameof(GetLists))]
public int SumEnumerable(IEnumerable<int> list)
{
int sum = 0;
foreach (int item in list)
{
sum += item;
}
return sum;
}
public static IEnumerable<List<int>> GetLists() =>
from count in new int[] { 1, 10, 1_000 }
select Enumerable.Range(0, count).ToList();
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.