JIT: Always introduce temps for ldarga'd parameters when inlining
#112051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed that we end up bailing from inlining in cases like the
following because we end up in a case where we have to take the address
of an rvalue when importing `ldarga`.
```
static void Foo()
{
S x = default;
Foo(&x);
}
[MethodImpl(MethodImplOptions.AggressiveInlining)]
static unsafe void Bar(S* px)
{
Bar(&px);
}
```
Very uncommon case, but the fix is simple.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
In the end this is subsumed by #112010 as I ended up generalizing this logic to fix some regressions in that PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that we end up bailing from inlining in cases like the following because we end up in a case where we have to take the address of an rvalue when importing
ldarga.Barhere fails to inline intoFoo. Very uncommon case, but the fix is simple.