Remove unused build controls and simplify DotNetBuild.props #111986
+7
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty sets we had to do to work around overriding it.
jkoritzinsky
added
source-build
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
|
Do you have VMR/source builds with these changes? |
ViktorHofer
reviewed
Jan 30, 2025
…f property sets we had to do to work around overriding it." This reverts commit 4fbfd7c.
ViktorHofer
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove controls that aren't used in the VMR. Don't override the "inner source build command" so we get globally set properties for free like every other repo in the VMR.