[release/9.0] Fix Encoding regression #111367
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #110521
Backport of #111320 to release/9.0
/cc @tarekgh
Customer Impact
In .NET 9.0, users working with multi-byte encodings like
GB18030
may encounter unexpected exceptions when decoding bytes into a Unicode surrogate pair. It's important to note that encoding can be used implicitly, such as when reading streams, which significantly broadens the potential impact of this issue.Regression
This is a regression in .NET 9.0 from the change #97950. The change has modified the logic in
EncodingCharBuffer.AddChar
to handle uninitialized chars differently causing regression.Testing
The regression tests have passed. I manually debugged the specific scenario and confirmed that the fix is effective. Additionally, I added a test case to cover the previous failure, ensuring that this regression will be detected if it occurs again in the future.
Risk
Low, we didn't change any logic more than handling the failing case when dealing with null buffers.
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging
, notrelease/X.0
.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.