[release/9.0-staging] Support generic fields in PersistedAssemblyBuilder #110839
+95
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/area-system-reflection-emit |
jkotas
approved these changes
Dec 19, 2024
|
@steveharter friendly reminder that today's code complete for the Feb 2025 Release. Please merge this change by 4pm PT if you'd like it included in that release version. Otherwise, it will have to wait until next month. |
|
@rbhanda why was "servicing-consider" removed? |
|
@rbhanda I think your intention was to change it to servicing-approved. I can tell because you set the milestone to 9.0.2. |
|
@steveharter if we want this included in the Feb release, I sent you the instructions to Teams. PTAL ASAP. |
rbhanda
added
Servicing-approved
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/12796250634 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #110372 to release/9.0-staging
/cc @steveharter
Customer Impact
The new
PersistableAssemblyBuilderfunctionality added in v9 has a bug where generic fields do not generate the proper IL, causing a generic field to be generated as non-generic.Regression
This was new functionality added in v9.
Testing
The original author's repro was verified and a test added that inspects the generated field's metadata to make sure the field is generic.
Risk
Low; the fix is fairly straightforward and follows other similar cases where we need to use metadata from open generic types instead of the closed generic type.