Skip to content

Commit

Permalink
Mark GCStressIncompatible and similar tests as out-of-proc (#67876)
Browse files Browse the repository at this point in the history
According to current architecture we must mark conditionally
enabled tests as out of process because the special conditions
are tested in their individual execution scripts that are skipped
for ordinary merged tests.

Thanks

Tomas
  • Loading branch information
trylek authored Apr 12, 2022
1 parent 78b66a1 commit 3635e0f
Show file tree
Hide file tree
Showing 46 changed files with 46 additions and 1 deletion.
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/Arrays/lcs/lcs2_d.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<DebugType>Full</DebugType>
<Optimize>False</Optimize>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<ItemGroup>
<Compile Include="lcs2.cs" />
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/Arrays/lcs/lcs2_do.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<DebugType>Full</DebugType>
<Optimize>True</Optimize>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<ItemGroup>
<Compile Include="lcs2.cs" />
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/Arrays/lcs/lcs2_r.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<DebugType>None</DebugType>
<Optimize>False</Optimize>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<ItemGroup>
<Compile Include="lcs2.cs" />
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/Arrays/lcs/lcs2_ro.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<DebugType>None</DebugType>
<Optimize>True</Optimize>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<ItemGroup>
<Compile Include="lcs2.cs" />
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/Arrays/lcs/lcsvalbox_d.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<PropertyGroup>
<OutputType>Exe</OutputType>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<PropertyGroup>
<DebugType>Full</DebugType>
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/Arrays/lcs/lcsvalbox_do.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<PropertyGroup>
<OutputType>Exe</OutputType>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<PropertyGroup>
<DebugType>Full</DebugType>
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/Arrays/lcs/lcsvalbox_r.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<PropertyGroup>
<OutputType>Exe</OutputType>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<PropertyGroup>
<DebugType>None</DebugType>
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/Arrays/lcs/lcsvalbox_ro.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<PropertyGroup>
<OutputType>Exe</OutputType>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<PropertyGroup>
<DebugType>None</DebugType>
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/Boxing/misc/concurgc_il_d.ilproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<RestorePackages>true</RestorePackages>
<!-- The test leaves a secondary thread running -->
<UnloadabilityIncompatible>true</UnloadabilityIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
<CLRTestPriority>1</CLRTestPriority>
</PropertyGroup>
<PropertyGroup>
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/Boxing/misc/concurgc_il_r.ilproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<RestorePackages>true</RestorePackages>
<!-- The test leaves a secondary thread running -->
<UnloadabilityIncompatible>true</UnloadabilityIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
<CLRTestPriority>1</CLRTestPriority>
</PropertyGroup>
<PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk.IL">
<PropertyGroup>
<MonoAotIncompatible>true</MonoAotIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<PropertyGroup>
<DebugType>PdbOnly</DebugType>
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/VT/port/lcs_gcref_d.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<PropertyGroup>
<OutputType>Exe</OutputType>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<PropertyGroup>
<DebugType>Full</DebugType>
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/VT/port/lcs_gcref_do.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<PropertyGroup>
<OutputType>Exe</OutputType>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<PropertyGroup>
<DebugType>Full</DebugType>
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/VT/port/lcs_gcref_r.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<PropertyGroup>
<OutputType>Exe</OutputType>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<PropertyGroup>
<DebugType>None</DebugType>
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/VT/port/lcs_gcref_ro.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<PropertyGroup>
<OutputType>Exe</OutputType>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<PropertyGroup>
<DebugType>None</DebugType>
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/doublearray/dblarray1_cs_d.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<DebugType>Full</DebugType>
<Optimize>False</Optimize>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<ItemGroup>
<Compile Include="dblarray1.cs" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<DebugType>Full</DebugType>
<Optimize>True</Optimize>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<ItemGroup>
<Compile Include="dblarray1.cs" />
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/doublearray/dblarray1_cs_r.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<DebugType>None</DebugType>
<Optimize>False</Optimize>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<ItemGroup>
<Compile Include="dblarray1.cs" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<DebugType>None</DebugType>
<Optimize>True</Optimize>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<ItemGroup>
<Compile Include="dblarray1.cs" />
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/doublearray/dblarray2_cs_d.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<DebugType>Full</DebugType>
<Optimize>False</Optimize>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<ItemGroup>
<Compile Include="dblarray2.cs" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<DebugType>Full</DebugType>
<Optimize>True</Optimize>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<ItemGroup>
<Compile Include="dblarray2.cs" />
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/doublearray/dblarray2_cs_r.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<DebugType>None</DebugType>
<Optimize>False</Optimize>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<ItemGroup>
<Compile Include="dblarray2.cs" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<DebugType>None</DebugType>
<Optimize>True</Optimize>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<ItemGroup>
<Compile Include="dblarray2.cs" />
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/doublearray/dblarray3_cs_d.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<DebugType>Full</DebugType>
<Optimize>False</Optimize>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<ItemGroup>
<Compile Include="dblarray3.cs" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<DebugType>Full</DebugType>
<Optimize>True</Optimize>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<ItemGroup>
<Compile Include="dblarray3.cs" />
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/doublearray/dblarray3_cs_r.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<DebugType>None</DebugType>
<Optimize>False</Optimize>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<ItemGroup>
<Compile Include="dblarray3.cs" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<DebugType>None</DebugType>
<Optimize>True</Optimize>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<ItemGroup>
<Compile Include="dblarray3.cs" />
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/doublearray/dblarray4_cs_d.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<DebugType>Full</DebugType>
<Optimize>False</Optimize>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<ItemGroup>
<Compile Include="dblarray4.cs" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<DebugType>Full</DebugType>
<Optimize>True</Optimize>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<ItemGroup>
<Compile Include="dblarray4.cs" />
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/doublearray/dblarray4_cs_r.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<DebugType>None</DebugType>
<Optimize>False</Optimize>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<ItemGroup>
<Compile Include="dblarray4.cs" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<DebugType>None</DebugType>
<Optimize>True</Optimize>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<ItemGroup>
<Compile Include="dblarray4.cs" />
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk.IL">
<PropertyGroup>
<MonoAotIncompatible>true</MonoAotIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<PropertyGroup>
<DebugType>Full</DebugType>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk.IL">
<PropertyGroup>
<MonoAotIncompatible>true</MonoAotIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<PropertyGroup>
<DebugType>PdbOnly</DebugType>
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/explicit/basic/refarg_i1_d.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<OutputType>Exe</OutputType>
<!-- TestAssemblyLoadContext.Load called from the finalizer -->
<UnloadabilityIncompatible>true</UnloadabilityIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
<CLRTestPriority>1</CLRTestPriority>
</PropertyGroup>
<PropertyGroup>
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/explicit/basic/refarg_i1_r.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<OutputType>Exe</OutputType>
<!-- TestAssemblyLoadContext.Load called from the finalizer -->
<UnloadabilityIncompatible>true</UnloadabilityIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
<CLRTestPriority>1</CLRTestPriority>
</PropertyGroup>
<PropertyGroup>
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/fp/exgen/10w5d_cs_d.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<!-- NOTE: this test simply takes too long to complete under GC stress/heap verify; it is not fundamentally incompatible -->
<GCStressIncompatible Condition="'$(TargetArchitecture)' == 'x86'">true</GCStressIncompatible>
<HeapVerifyIncompatible>true</HeapVerifyIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<PropertyGroup>
<DebugType>Full</DebugType>
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/fp/exgen/10w5d_cs_r.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<!-- NOTE: this test simply takes too long to complete under GC stress/heap verify; it is not fundamentally incompatible -->
<GCStressIncompatible Condition="'$(TargetArchitecture)' == 'x86'">true</GCStressIncompatible>
<HeapVerifyIncompatible>true</HeapVerifyIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<PropertyGroup>
<DebugType>None</DebugType>
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/refany/stress1_d.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<PropertyGroup>
<OutputType>Exe</OutputType>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<PropertyGroup>
<DebugType>Full</DebugType>
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/refany/stress1_r.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<PropertyGroup>
<OutputType>Exe</OutputType>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<PropertyGroup>
<DebugType>None</DebugType>
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/refany/stress1_ro.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<PropertyGroup>
<OutputType>Exe</OutputType>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<PropertyGroup>
<DebugType>None</DebugType>
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/refany/virtcall_d.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<PropertyGroup>
<OutputType>Exe</OutputType>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<PropertyGroup>
<DebugType>Full</DebugType>
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/refany/virtcall_do.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<PropertyGroup>
<OutputType>Exe</OutputType>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<PropertyGroup>
<DebugType>Full</DebugType>
Expand Down
2 changes: 1 addition & 1 deletion src/tests/JIT/Methodical/refany/virtcall_r.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
<PropertyGroup>
<OutputType>Exe</OutputType>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<PropertyGroup>
<DebugType>None</DebugType>
<Optimize>False</Optimize>
<GCStressIncompatible>true</GCStressIncompatible>
</PropertyGroup>
<ItemGroup>
<Compile Include="virtcall.cs" />
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/refany/virtcall_ro.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<DebugType>None</DebugType>
<Optimize>True</Optimize>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<ItemGroup>
<Compile Include="virtcall.cs" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<!-- NOTE: this test simply takes too long to complete under heap verify or GCStress. It is not fundamentally incompatible. -->
<HeapVerifyIncompatible>true</HeapVerifyIncompatible>
<GCStressIncompatible>true</GCStressIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
<IsLongRunningGCTest>true</IsLongRunningGCTest>
<CLRTestPriority>1</CLRTestPriority>
</PropertyGroup>
Expand Down
1 change: 1 addition & 0 deletions src/tests/JIT/Methodical/tailcall_v4/hijacking.ilproj
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<GCStressIncompatible Condition="'$(TargetArchitecture)' == 'arm64' and '$(TargetOS)' == 'OSX'">true</GCStressIncompatible>
<!-- NOTE: this test simply takes too long to complete under heap verify. It is not fundamentally incompatible. -->
<HeapVerifyIncompatible Condition="'$(TargetArchitecture)' == 'x86'">true</HeapVerifyIncompatible>
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
<PropertyGroup>
<DebugType>PdbOnly</DebugType>
Expand Down

0 comments on commit 3635e0f

Please sign in to comment.