Allow VS extensions to participate in Roslyn OOP MEF: #79219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow extensions to supply a set of RoslynOopMefComponent - Load those from extensions and pass them over to the OOP process at init - Add the passed assembly paths into the OOP MEF catalog construction
chsienki
commented
Jul 1, 2025
| @@ -15,5 +16,5 @@ internal interface IRemoteInitializationService | |||
| /// Called as soon as the remote process is created. | |||
| /// </summary> | |||
| /// <returns>Process ID of the remote process and an error message if the server encountered initialization issues.</returns> | |||
| ValueTask<(int processId, string? errorMessage)> InitializeAsync(WorkspaceConfigurationOptions options, string localSettingsDirectory, CancellationToken cancellationToken); | |||
| ValueTask<(int processId, string? errorMessage)> InitializeAsync(WorkspaceConfigurationOptions options, string localSettingsDirectory, ImmutableArray<string> oopMefComponentPaths, CancellationToken cancellationToken); | |||
There was a problem hiding this comment.
Should probably rename this something like RemoteMefComponentAssemblyPaths
|
@dibarbet to make sure this aligns with the gladstone experiment to load extensions. |
| @@ -23,7 +23,7 @@ internal sealed partial class VisualStudioDiagnosticAnalyzerProvider | |||
| { | |||
| private const string AnalyzerContentTypeName = "Microsoft.VisualStudio.Analyzer"; | |||
|
|
|||
| internal const string RazorContentTypeName = "Microsoft.VisualStudio.RazorAssembly"; | |||
| internal const string RoslynOopMefContentName = "Microsoft.VisualStudio.RoslynOopMefComponent"; | |||
There was a problem hiding this comment.
Suggested change
| internal const string RoslynOopMefContentName = "Microsoft.VisualStudio.RoslynOopMefComponent"; | |
| internal const string RoslynOopMefContentName = "Microsoft.VisualStudio.RoslynOopMefComponent"; |
Nit: maybe call it RoslynServiceHubMefComponent. Only because I agree that you correctly applied .NET casing rules to the "OOP" but anybody seeing it might be confused.
There was a problem hiding this comment.
Obviously when you undraft this we should rename this type.
Comment on lines
+104
to
+106
| // If that fails, try and load it from the codeBasePath if present | ||
| var selfAlc = System.Runtime.Loader.AssemblyLoadContext.GetLoadContext(Assembly.GetExecutingAssembly())!; | ||
| return selfAlc.LoadFromAssemblyPath(codeBasePath); |
There was a problem hiding this comment.
We'd have to think about what this means for dependnecies though of your MEF component. Should we put you generally into an ALC? We do similar things in VS Code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71510