Skip to content

[Android] Setup infrastructure around Android sample app for AOT/R2R testings #4808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2025
Merged

[Android] Setup infrastructure around Android sample app for AOT/R2R testings #4808

merged 1 commit into from
Apr 3, 2025

Conversation

matouskozak
Copy link
Member

@matouskozak matouskozak commented Apr 1, 2025 •
edited
Loading

  • Added Mono AOT and CoreCLR R2R scenario for dotnet/runtime Android sample app.
  • Added codeGenType parameter to android scenarios with JIT/AOT/R2R values.
  • Ensured that RuntimeFlavor and CodegenType is passed over to helix.

Test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2676838
Associated dotnet/runtime PR: dotnet/runtime#114117

@matouskozak matouskozak added enhancement New feature or request Scenario labels Apr 1, 2025
@matouskozak matouskozak self-assigned this Apr 1, 2025
@matouskozak matouskozak mentioned this pull request Apr 1, 2025
Merged
@matouskozak matouskozak marked this pull request as ready for review April 2, 2025 08:11
e-kharion
e-kharion approved these changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@e-kharion e-kharion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LoopedBard3
LoopedBard3 approved these changes Apr 2, 2025
View reviewed changes
Copy link
Member

@LoopedBard3 LoopedBard3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for finishing the changes!

@LoopedBard3 LoopedBard3 merged commit c19483f into dotnet:main Apr 3, 2025
73 of 83 checks passed
@matouskozak matouskozak mentioned this pull request Apr 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoopedBard3 LoopedBard3 LoopedBard3 approved these changes

@caaavik-msft caaavik-msft caaavik-msft approved these changes

@e-kharion e-kharion e-kharion approved these changes

@ivanpovazan ivanpovazan Awaiting requested review from ivanpovazan

Assignees

@matouskozak matouskozak

Labels
enhancement New feature or request Scenario
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matouskozak @LoopedBard3 @caaavik-msft @e-kharion