Skip to content

Reduce allocations in LazyItemEvaluator.ProcessMetadataElements by avoiding enumerator boxing #12908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JanProvaznik merged 5 commits into from
Dec 18, 2025
+2 −2
Merged

Reduce allocations in LazyItemEvaluator.ProcessMetadataElements by avoiding enumerator boxing #12908

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f4f9f94
Reduce allocations in LazyItemEvaluator.ProcessMetadataElements by av…
Dec 9, 2025
edd1a0c
Merge branch 'main' into dev/nareshjo/processmetadataelementsboxing
YuliiaKovalova Dec 11, 2025
8fba98d
Merge branch 'main' into dev/nareshjo/processmetadataelementsboxing
nareshjo Dec 12, 2025
fa146f3
Merge branch 'main' into dev/nareshjo/processmetadataelementsboxing
nareshjo Dec 15, 2025
1ce6157
Merge branch 'main' into dev/nareshjo/processmetadataelementsboxing
nareshjo Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Build/Evaluation/LazyItemEvaluator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,8 +629,6 @@ private void ProcessMetadataElements(ProjectItemElement itemElement, OperationBu
{
if (itemElement.HasMetadata)
{
operationBuilder.Metadata.AddRange(itemElement.Metadata);

ItemsAndMetadataPair itemsAndMetadataFound = new ItemsAndMetadataPair(null, null);

// Since we're just attempting to expand properties in order to find referenced items and not expanding metadata,
Expand All @@ -639,6 +637,8 @@ private void ProcessMetadataElements(ProjectItemElement itemElement, OperationBu
const ExpanderOptions expanderOptions = ExpanderOptions.ExpandProperties | ExpanderOptions.LeavePropertiesUnexpandedOnError;
foreach (var metadatumElement in itemElement.Metadata)
{
operationBuilder.Metadata.Add(metadatumElement);

string expression = _expander.ExpandIntoStringLeaveEscaped(
metadatumElement.Value,
expanderOptions,
Expand Down