Skip to content

Commit

Permalink
Add a note about the necessity to keep BuildEventArgsWriter AND Struc…
Browse files Browse the repository at this point in the history
…turedLogViewer.BuildEventArgsWriter consistent (#10580)
  • Loading branch information
YuliiaKovalova authored Sep 13, 2024
1 parent 8500d97 commit e4797f3
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/Build/Logging/BinaryLogger/BinaryLogger.cs
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,9 @@ public sealed class BinaryLogger : ILogger
// - new record kinds: BuildCheckMessageEvent, BuildCheckWarningEvent, BuildCheckErrorEvent,
// BuildCheckTracingEvent, BuildCheckAcquisitionEvent, BuildSubmissionStartedEvent

// MAKE SURE YOU KEEP BuildEventArgsWriter AND StructuredLogViewer.BuildEventArgsWriter IN SYNC WITH THE CHANGES ABOVE.
// Both components must stay in sync to avoid issues with logging or event handling in the products.

// This should be never changed.
// The minimum version of the binary log reader that can read log of above version.
internal const int ForwardCompatibilityMinimalVersion = 18;
Expand Down

0 comments on commit e4797f3

Please sign in to comment.