Try fixing the RunOniOS failing test stage #33047
Open
+30
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix failing iOS test stages by improving the reliability of simulator boot detection. The issue was that the simctl boot command can return successfully before the simulator is fully ready to accept app launches, causing subsequent operations to fail.
Key Changes
- Added a
WaitForSimulatorReadymethod that polls the simulator's boot status usingsimctl bootstatus - Modified the
Launchmethod to wait for the simulator to be fully booted with a 60-second timeout - Implemented a polling loop with 2-second intervals to check boot readiness
Contributor
|
@jfversluis I've opened a new pull request, #33049, to work on those changes. Once the pull request is ready, I'll request review from you. |
* Initial plan * Print simulator boot status output for diagnostics Co-authored-by: jfversluis <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: jfversluis <[email protected]>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 33047Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 33047" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.