Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[net10.0, Testing] Enabled failed UITests for Switch control due to new OffColor API. #28495

Open
wants to merge 6 commits into
base: net10.0
Choose a base branch
from
Open

[net10.0, Testing] Enabled failed UITests for Switch control due to new OffColor API. #28495

wants to merge 6 commits into from

Conversation

HarishKumarSF4517
Copy link
Contributor

@HarishKumarSF4517 HarishKumarSF4517 commented Mar 19, 2025 •
edited
Loading

This PR addresses the issue of failed UITests for the Switch control after the .NET 10.0 update. The failure was caused by the introduction of the OffColor API in the Switch control, which led to visual differences in UITest image comparisons.

Refrence: https://github.com/dotnet/maui/pull/25068/files

TestCases

  • Issue23608
  • Issue8263
  • Issue15695

Issues Fixed

Fixes #28358

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Mar 19, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Hey there @HarishKumarSF4517! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Mar 19, 2025
@anandhan-rajagopal anandhan-rajagopal added the area-testing Unit tests, device tests label Mar 19, 2025
@HarishKumarSF4517 HarishKumarSF4517 marked this pull request as ready for review March 19, 2025 06:22
@Copilot Copilot bot review requested due to automatic review settings March 19, 2025 06:22
@HarishKumarSF4517 HarishKumarSF4517 requested a review from a team as a code owner March 19, 2025 06:22
Copilot
Copilot AI reviewed Mar 19, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR re-enables UI tests for the Switch control that were previously disabled with conditional compilation due to failures caused by the new OffColor API in .NET 10.0.

  • Removed conditional compilation directives for tests Issue15695, Issue23608, and Issue8263 to run tests across all platforms.
  • Enabled tests that were disabled under specific platform conditions to assess UI changes resulting from the OffColor API update.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

File Description
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue15695.cs Removed #if/#endif directives to always run the test.
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue23608.cs Removed #if/#endif directives to always run the test.
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue8263.cs Removed #if/#endif directives to always run the test.

@jsuarezruiz jsuarezruiz self-requested a review March 19, 2025 07:03
jsuarezruiz
jsuarezruiz requested changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we include the UpdatedIsEnabledProperty.png for Mac this PR too?

@HarishKumarSF4517
Copy link
Contributor Author

HarishKumarSF4517 commented Mar 25, 2025 •
edited
Loading

Could we include the UpdatedIsEnabledProperty.png for Mac this PR too?

Hi @jsuarezruiz ,
As the locally generated images for Mac are still not suitable for CI environments, we need to initiate a CI pipeline that specifically targets the net10.0 branch to retrieve and update the images. Could you please let us know if there are any other options available for generating and updating the Mac images locally?

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

Could we include the UpdatedIsEnabledProperty.png for Mac this PR too?

Hi @jsuarezruiz , As the locally generated images for Mac are still not suitable for CI environments, we need to initiate a CI pipeline that specifically targets the net10.0 branch to retrieve and update the images. Could you please let us know if there are any other options available for generating and updating the Mac images locally?

Running a build.

rmarinho
rmarinho requested changes Mar 26, 2025
View reviewed changes
Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-03-26 at 12 40 19

Seems tests are failing for Mac and winui . Also please make sure yo rebase the branch for next run

@rmarinho
Copy link
Member

/rebase

jsuarezruiz
jsuarezruiz requested changes Mar 26, 2025
View reviewed changes
...trols/tests/TestCases.Mac.Tests/snapshots/mac/VerifySwitchOffColorAfterTogglingDarkTheme.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Switch appears cut off here.

src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/VerifySwitchOffColorAfterToggling.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Switch appears cut off here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jsuarezruiz ,
The cut-off appearance of the Switch is only present in the CI view. It passes as expected locally on my machine, so this seems to be specific to the CI environment.

@rmarinho
Copy link
Member

/rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@rmarinho rmarinho rmarinho requested changes

@jsuarezruiz jsuarezruiz jsuarezruiz requested changes

@PureWeen PureWeen Awaiting requested review from PureWeen PureWeen is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@tj-devel709 tj-devel709 Awaiting requested review from tj-devel709 tj-devel709 is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
area-testing Unit tests, device tests community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HarishKumarSF4517 @jsuarezruiz @rmarinho @anandhan-rajagopal