[X] Make OnPlatformExtension and OnIdiomExtension trim-compatible #26119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
I revisited the
OnIdiomExtensionandOnPlatformExtensionbased on customer feedback and I've realized the only trim-incompatible part of the code is creating default value for value types. This seems like a weird edge case and I believe we should throw so the developer fixes the XAML.This would be a breaking change though. If approved, this PR shouldn't be included in servicing releases.
Issues Fixed
Fixes #26115
/cc @StephaneDelcroix @PureWeen