Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[net9.0] Merge main into net9.0 (take 3) #24822

Open
wants to merge 48 commits into
base: net9.0
Choose a base branch
from

Commits on Jul 4, 2024

  1. Configuration menu
    Copy the full SHA
    69e8907 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Fix SafeArea adjustments (#23729)

    * Fix SafeArea adjustments
    
    * - fix
    PureWeen committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    14b29b0 View commit details
    Browse the repository at this point in the history
  2. Fix shadow consistency on Android and iOS (#24415)

    * Fix shadow consistency on Android and iOS
    
    * Update test screenshots
    albyrock87 committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    642a352 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. [Android & iOS] dialog theme change on changing UserAppTheme (#24559)

    * [Android & iOS] dialog theme change on changing UserAppTheme
    
    * Update Application.cs
    kubaflo committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    182c55a View commit details
    Browse the repository at this point in the history
  2. Revert "894511 : Shell Tab is still visible after set Tab.IsVisible t…

    …o false …" (#24588)
    
    This reverts commit 1dfe609.
    PureWeen committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    049bfdf View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5c0e6d6 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Revert "Fix SafeArea adjustments (#23729)" (#24600)

    This reverts commit 14b29b0.
    PureWeen committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    9522861 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1a2c80f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    31e3d59 View commit details
    Browse the repository at this point in the history
  4. UI testing doc changes (#24165)

    * Added note to ignore device tests
    
    * Update note for new devs, Added section on VerifyScreenshots, Explanation about AutomationId
    
    * Removed Fixture Setup/Teardown
    
    * Moved paragraphs around and added new subheadings to make it easier to read. Used correct formatting for class names. Removed GalleryPage content. Removed some redundant content.
    
    * Added note about FailsOn attribute, elaborated on DeviceTests note
    
    * Fixed spelling errors
    
    * Alternate word
    
    * Added back the bit about GalleryPage
    
    * Fixed incorrect link for DeviceTests, added bit about Issue text
    
    * Redid intro
    
    * Added screenshots to the VerifyScreenshots section
    
    * Removed section
    
    * Added info about logging
    
    * Fixed screenshot tags
    
    * One more tag fix
    
    * Fixed spelling, added some syntax formatting
    
    * Addressed comments
    
    * Changed links to permalinks
    
    * Added pic of failed test screenshot
    dustin-wojciechowski committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    84e46ba View commit details
    Browse the repository at this point in the history
  5. Null guard in `ShellFlyoutTemplatedContentRenderer.HeaderContainer.Up…

    …dateMinimumHeight` (#16573)
    
    * Null guard
    
    * Update ShellFlyoutTemplatedContentRenderer.cs
    
    * Update ShellFlyoutTemplatedContentRenderer.cs
    
    ---------
    
    Co-authored-by: Shane Neuville <[email protected]>
    BioTurboNick and PureWeen committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    afc1f5c View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Configuration menu
    Copy the full SHA
    5b99501 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bc5b90b View commit details
    Browse the repository at this point in the history
  3. Resolved Text Jump Issue in Entry Control with HorizontalTextAlignmen…

    …t Set to End (#24485)
    
    * fix-24405-Fixed-Entry-Text-Alignment-Issue
    
    * Fix-24405-Removed local variable and added old comment.
    
    * fix-24405-Testcase sample updated.
    
    * Fix-24405-Test case changes committed.
    
    * fix-24405-Updated new logic.
    
    * fix-24405-Test script changes committed.
    
    * fix-24405-Modified script and sample files.
    
    * fix-24405-Modified test sample code.
    
    * Fix-24405-Snapshots added for windows, iOS and Android.
    
    * Fix-24405-Updated Testscript method name.
    BagavathiPerumal committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    9486321 View commit details
    Browse the repository at this point in the history
  4. Improve Android device type check and improve UI Test cake scripts (#…

    …24495)
    
    * Improve Android device type check to use screen size
    
    For Android visual tests, they should be run with the right
    device image (currently a Nexus 5X API 30). However,
    there's no easy way to check the device type for Appium.
    The check that was there before works on CI
    since the DEVICE_SKIN environment variable is set there
    (set by the android.cake script). And it can work locally if
    folks run android.cake then launch VS from that console
    session to get the env variable - but it doesn't work if VS
    is run separately (normal case).
    
    So update this with a different check. Getting the actual
    Android device type requires using adb. We might eventually
    do that, but for now just use a screen size check as a proxy
    for the device type. Also update the failure message to give
    good instructions.
    
    * Add a "uitest-prepare" target to android.cake
    
    uitest-prepare will build the test app, launch
    the emulator, and deploy the test app. But
    it won't actually run any tests.
    
    * Validate that JAVA_HOME is set
    
    Also display the Android image name
    
    * Check Android device capabilties for a match
    
    * Add uitest-prepare target for ios.cake to match android
    BretJohnson committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    566b859 View commit details
    Browse the repository at this point in the history
  5. Improve performance and stability of BindableLayout (#23136)

    * Improve performance and stability of `BindableLayout`
    Fixes #23135
    Fixes #10918
    
    * Remove `IDispatcher` from `BindableLayout` enhancements
    
    * Fix empty view not removed when adding an item on an empty observable collection
    
    * Adjust MemoryTests to account for the improved `BindableLayout` behavior
    albyrock87 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    bcba26f View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2024

  1. Configuration menu
    Copy the full SHA
    336f7f4 View commit details
    Browse the repository at this point in the history
  2. Fix border lagging and unwanted animations on iOS (#24360)

    * Fix border lagging and unwanted animations on iOS
    
    * Update src/Core/src/Platform/iOS/StrokeExtensions.cs
    
    Co-authored-by: MartyIX <[email protected]>
    
    * Add some control on the test case
    
    * Ensure every CALayer used by MAUI does not use animations.
    
    ---------
    
    Co-authored-by: MartyIX <[email protected]>
    albyrock87 and MartyIX committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    2c7458e View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2024

  1. [Android] invalidate shadows on parent's size change (#24561)

    * [Android] invalidate shadows on parent's size change
    
    * Update WrapperView.cs
    
    * Added snapshots
    kubaflo committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    c89f12c View commit details
    Browse the repository at this point in the history
  2. Fix layout when MinimumWidth/HeightRequest is removed on Windows (#24639

    )
    
    * Fix layout when MinimumWidth/HeightRequest is removed on Windows
    
    * Request smaller sizes to see if it fixes tests
    
    * Use AssertionExtensions.AssertEventually to test layout values
    spadapet committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    cf00253 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Configuration menu
    Copy the full SHA
    68f6e4b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    277ce9f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    45a1666 View commit details
    Browse the repository at this point in the history
  4. Update dependencies from https://github.com/dotnet/xharness build 202…

    …40909.1 (#24673)
    
    Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
     From Version 9.0.0-prerelease.24420.3 -> To Version 10.0.0-prerelease.24459.1
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    dotnet-maestro[bot] and dotnet-maestro[bot] committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    75580dd View commit details
    Browse the repository at this point in the history
  5. Update script to generate Public API filess (#24631)

    * Update script to generate PublicAPIs
    
    * Update mark-shipped.ps1
    
    * Update mark-shipped.ps1
    mattleibow committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    0440139 View commit details
    Browse the repository at this point in the history
  6. changed order of calls to properly close Picker Activity / ViewContro…

    …ller and set the picker result (#21998)
    Alex-Dobrynin committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    79bef03 View commit details
    Browse the repository at this point in the history
  7. Don't invalidate SuperView if not connected to Window (#24637)

    * Don't invalidate SuperView if not connected to Window
    
    * - fix test to run better on all platforms
    PureWeen committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    72aa284 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    89b11fe View commit details
    Browse the repository at this point in the history
  9. [iOS] SwipeView: Fix reenabling parent scrolling after cancelled swipe (

    #23442)
    
    ### Description of Change
    
    Fixes an issue where scrolling of SwipeView's parent is disabled during
    swipe but not reenabled when the swipe is cancelled by manually moving
    the touch below the threshold.
    
    ### Issues Fixed
    
    Fixes #23441 
    Fixes #16856
    Redth committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    760cbb2 View commit details
    Browse the repository at this point in the history
  10. [Testing] Split off HandlerDoesNotLeak.DatePicker into its own UI test (

    #24585)
    
    * Split off DatePicker.HandlerDoesNotLeak into its own UI test.
    
    * Changed RunMemoryTest to take in INavigation instead of NavigationPage, renamed Issue24147 to MemoryTests and changed it to take in Text from Entry to determine which Handler to use, Removed Issue22072 as that's now in MemoryTests
    
    * Renamed Issue24147 in Tests.Shared to MemoryTests, added methods to check DatePicker and WebView. Added automationids in HostApp MemoryTests
    dustin-wojciechowski committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    9d965cc View commit details
    Browse the repository at this point in the history
  11. Make sure that Navigation Pages fill the screen (#24651)

    * Make sure that Navigation Pages fill the screen
    
    * Update Issue23484.cs
    
    * - add arrange back in
    PureWeen committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    a7ffadf View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Editor completed event is not triggered properly when unfocused (#24207)

    * 899474 :[Android]Editor/Entry controls don't raise Completed event
    
    * Test cases update commit
    
    * commit for UI changes
    
    * Commit for platform definition
    
    * commit for review changes
    
    * 899474: Image Added
    
    * Update Issue9796.cs
    
    * Update Issue9796.cs
    
    * Review changes for Testcases
    
    * Image commit
    
    * Update Issue9796.cs
    
    * 899474:Removing the entry codes
    
    * Update EntryHandler.Android.cs
    
    * Changes for test case
    
    * Update Issue9796.xaml.cs
    
    * Review changes
    
    * commit for review changes
    
    * Update Issue9796.cs
    
    * Update Issue9796.cs
    SuthiYuvaraj committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    8ee7227 View commit details
    Browse the repository at this point in the history
  2. [xamlc] return early in NodeILExtensions for ValidateOnly (#24493)

    Context: 7efca8e
    Context: xamarin/Xamarin.Forms#7407
    
    For Debug builds, .NET MAUI runs XamlC in a "ValidateOnly" mode, which
    avoids writing `.dll` files at the end. This way, we get faster
    builds, but still emit the same errors and warnings that would be
    emitted in `Release` mode.
    
    Right now, the `ValidateOnly` flag is only checked at the end of the
    process to skip writing files. I looked for some places taking time,
    such as:
    
        36.30ms (1.1%) microsoft.maui.controls.build.tasks!Microsoft.Maui.Controls.Build.Tasks.NodeILExtensions+<PushServiceProvider>d__12.MoveNext()
        20.20ms (0.6%) microsoft.maui.controls.build.tasks!Microsoft.Maui.Controls.Build.Tasks.NodeILExtensions+<PushParentObjectsArray>d__9.MoveNext()
         1.21ms (0.0%) microsoft.maui.controls.build.tasks!Microsoft.Maui.Controls.Build.Tasks.NodeILExtensions.PushXmlLineInfo(class Microsoft.Maui.Controls.Xaml.INode,class Microsoft.Maui.Controls.Build.Tasks.ILContext)
    
    And added checks to just return early in these methods.
    
    With this change in-place, an incremental build of a `dotnet new maui`
    project template:
    
        Before:
        1704 ms  XamlCTask                                  4 calls
        After:
        1402 ms  XamlCTask                                  4 calls
    
    This probably saves a little less than 100ms per call, but in this
    example it is running once per platform. This improvement probably
    will help even more for larger projects with many XAML files.
    jonathanpeppers committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    f7574dd View commit details
    Browse the repository at this point in the history
  3. [C] Allow OnIdiom/OnPlatform to return a Binding (#24594)

    * [C] Allow OnIdiom/OnPlatform to return a Binding
    
    - fixes #19388
    - fixes #18697
    - fixes #22877
    - closes #23798
    - closes #23272
    
    and some others
    
    * fix runtime cast
    
    - fixes #24500
    - fixes #16725
    StephaneDelcroix committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    9a78453 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dc27b9c View commit details
    Browse the repository at this point in the history
  5. Fix for the Nested Entry View In A Frame Causes Crash (#24543)

    * Committed the changes of the issue
    
    * properly fixed the Object disposed exception
    
    * Added the proper name of test case
    
    * Removing the unneccesary space
    
    * fix-15196-Removed the Dispose method.
    
    * fix-15196-Modified and removed the changes in test case and sample.
    
    ---------
    
    Co-authored-by: AhamedAliNishad <[email protected]>
    BagavathiPerumal and Ahamed-Ali committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    64343f5 View commit details
    Browse the repository at this point in the history
  6. [iOS] Fix for CollectionView single item horizontal alignment issue w…

    …hen using ItemsLayout with a Footer. (#24564)
    
    * fix added for collectionView single item alignment with footer,
    
    * Test sample changes.
    
    * Modified the automation sample.
    
    * Added automation images.
    
    * Added comments.
    Tamilarasan-Paranthaman committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    7d6c5a9 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Configuration menu
    Copy the full SHA
    0548772 View commit details
    Browse the repository at this point in the history
  2. Ensure disconnected ItemsViewHandler doesn't hold onto the items sour…

    …ce (#24699)
    
    * Ensure disconnected ItemsViewHandler doesn't hold onto the items source
    
    * Update CarouselViewTests.cs
    PureWeen committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    9055699 View commit details
    Browse the repository at this point in the history
  3. [IOS] - Fix error when running new template maui app on iOS (#24567)

    * Fixed - 22452 - ios Shell
    
    * Added Test case
    
    * Modified test case file
    
    * Modified test case
    
    * Added images for test case
    
    * Modified test case file
    
    * Modified test cases
    
    * Modified test case
    
    * Modified test case
    
    * Added image for test case
    NirmalKumarYuvaraj committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    19afb50 View commit details
    Browse the repository at this point in the history
  4. Clear out prototype cell when changing ItemSource (#24700)

    * Clear out prototype cell which changing ItemSource
    
    * Update ListViewTests.cs
    
    * Update ListViewTests.cs
    PureWeen committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    fd718a1 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Configuration menu
    Copy the full SHA
    049ec59 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. [C] Add ImageSource as LogicalChildren of MenuItem (#24688)

    * [C] Add ImageSource as LogicalChildren of MenuItem
    
    - fixes #20508
    
    * -fixes #23201 as well
    
    * well, it fixes another one too
    StephaneDelcroix committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    abec5a8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0de3f8a View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. Configuration menu
    Copy the full SHA
    3de5be9 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Configuration menu
    Copy the full SHA
    b2c1d25 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Update dependencies from https://github.com/dotnet/xharness build 202…

    …40916.1 (#24785)
    
    Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
     From Version 10.0.0-prerelease.24459.1 -> To Version 10.0.0-prerelease.24466.1
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    dotnet-maestro[bot] and dotnet-maestro[bot] committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    9648523 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' into merge-main-into-net9-again

    # Conflicts:
    #	eng/Version.Details.xml
    #	eng/Versions.props
    #	eng/devices/ios.cake
    #	src/Controls/src/Core/BindableObject.cs
    #	src/Controls/src/Core/Handlers/Items/CarouselViewHandler.Windows.cs
    #	src/Controls/src/Core/PublicAPI/net-android/PublicAPI.Unshipped.txt
    #	src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt
    #	src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt
    #	src/Controls/src/Core/PublicAPI/net-tizen/PublicAPI.Unshipped.txt
    #	src/Controls/src/Core/PublicAPI/net-windows/PublicAPI.Unshipped.txt
    #	src/Controls/src/Core/PublicAPI/net/PublicAPI.Unshipped.txt
    #	src/Controls/src/Core/PublicAPI/netstandard/PublicAPI.Unshipped.txt
    #	src/Controls/src/Xaml/PublicAPI/net-android/PublicAPI.Unshipped.txt
    #	src/Controls/src/Xaml/PublicAPI/net-ios/PublicAPI.Unshipped.txt
    #	src/Controls/src/Xaml/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt
    #	src/Controls/src/Xaml/PublicAPI/net-tizen/PublicAPI.Unshipped.txt
    #	src/Controls/src/Xaml/PublicAPI/net-windows/PublicAPI.Unshipped.txt
    #	src/Controls/src/Xaml/PublicAPI/net/PublicAPI.Unshipped.txt
    #	src/Controls/src/Xaml/PublicAPI/netstandard/PublicAPI.Unshipped.txt
    #	src/Core/src/Handlers/Application/ApplicationHandler.Android.cs
    #	src/Core/src/Handlers/Application/ApplicationHandler.cs
    #	src/Core/src/Platform/iOS/LabelExtensions.cs
    #	src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt
    #	src/Core/src/PublicAPI/net-ios/PublicAPI.Unshipped.txt
    #	src/Core/src/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt
    #	src/Core/src/PublicAPI/net-tizen/PublicAPI.Unshipped.txt
    #	src/Core/src/PublicAPI/net-windows/PublicAPI.Unshipped.txt
    #	src/Core/src/PublicAPI/net/PublicAPI.Unshipped.txt
    #	src/Core/src/PublicAPI/netstandard/PublicAPI.Unshipped.txt
    #	src/Core/src/PublicAPI/netstandard2.0/PublicAPI.Unshipped.txt
    #	src/Essentials/src/HapticFeedback/HapticFeedback.ios.cs
    #	src/Essentials/src/PublicAPI/net-android/PublicAPI.Unshipped.txt
    #	src/Essentials/src/PublicAPI/net-ios/PublicAPI.Unshipped.txt
    #	src/Essentials/src/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt
    #	src/Essentials/src/PublicAPI/net-tizen/PublicAPI.Unshipped.txt
    #	src/Essentials/src/PublicAPI/net-windows/PublicAPI.Unshipped.txt
    #	src/Essentials/src/PublicAPI/net/PublicAPI.Unshipped.txt
    #	src/Essentials/src/PublicAPI/netstandard/PublicAPI.Unshipped.txt
    #	src/Essentials/src/WebAuthenticator/WebAuthenticator.ios.tvos.cs
    mattleibow committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    e435420 View commit details
    Browse the repository at this point in the history