Fix ShellContent Title doesn't observe changes to bound properties #24806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @devanathan-vaithiyanathan! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
PureWeen
requested changes
Sep 20, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
approved these changes
Sep 24, 2024
samhouts
added
fixed-in-net9.0-nightly
samhouts
added
fixed-in-9.0.0-rc.2.24503.2
fixed-in-net8.0-nightly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause
The issue was due to the ShellContent title not updating dynamically in response to property changes. On Android, the title updates were not reflected in real time because the Title property changes were not being observed. On Windows, the title updates were not properly mapped to the native WinUI control.
Description of Change
Android: Enabled dynamic tab title updates by subscribing to the PropertyChanged event for BaseShellItem. Updated TitleProperty to TwoWay binding for real-time title updates in ShellSectionRenderer.
Windows: Mapped ShellContent title to the native WinUI control by calling UpdateTitle() in ShellItemHandler, ensuring title changes are reflected immediately in the UI.
Issues Fixed
Fixes #7453
Validated the behaviour in the following platforms
Output
Windows
2024-09-23.16-38-05.mp4
Android
Android.Emulator.-.pixel_6_-_api_30_5554.2024-09-23.16-46-15.mp4