TCA955x - making address check optional so this driver can be used with other c… #2425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ompatible chips with different address range.
dotnet-policy-service
bot
added
the
area-device-bindings
raffaeler
approved these changes
Sep 18, 2025
joperezr
approved these changes
Sep 18, 2025
There was a problem hiding this comment.
Thanks for the change @felixcollins. It is of course a binary breaking change but not a source breaking change. I think due to the value of it we should take it. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Tca955x constructor validates that the address of the passed in i2c device is in the correct range for the Tca955x family. This driver is useful for other register compatible devices that have different addressing schemes. This PR optionally turns off this check so that advanced users can deploy it for other devices.
Microsoft Reviewers: Open in CodeFlow