-
Notifications
You must be signed in to change notification settings - Fork 819
Fix parsing errors using anonymous records and units of measures #18543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❗ Release notes required
|
tests/FSharp.Compiler.ComponentTests/Conformance/Types/RecordTypes/AnonymousRecords.fs
Outdated
Show resolved
Hide resolved
Head branch was pushed to by a user without write access
Fixed again another merge conflict :( |
@T-Gro This is ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finishing this @edgarfgp .
I do realize that my wishes to guard even simple improvements can be annoying at times, but our focus should be at the user who does not watch language evolution closely.
The situation with up-to-date local and outdated CI is quite real.When it comes to parser/lexer improvememnts, those errors (not reproducible locally) would be confusing (well, as they are currently before this change...) and hard to fix blindly.
Description
Essentially the lexer could not understand
>|}
. So I followed the same approach that the existing>|]
handles this and then checked that in both cases produce the same AST.Fixes #10629
BEFORE
AFTER
Checklist