-
Notifications
You must be signed in to change notification settings - Fork 817
Allow let!
and use!
binding with type annotation without parentheses.
#18508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❗ Release notes required
|
It might be interesting in a follow up PR to add error recovery for cases where we have a let! x:
use! stream:
let x:
use x: Where we can use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the depth of test coverage here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really a nice addition @edgarfgp 👍 .
I think this is a change where we would be better with having a languageFeature guard with recovery.
Reason is, people might be having mismatched SDKs locally vs CI.
This change would allow code to pass locally, but then surprisingly fail parsing when ran on CI with a different SDK version.
LanguageVersion will cover for that scenario.
@T-Gro Updated as requested |
Description
Allow
let!
anduse!
binding with type annotation without parentheses.Fixes #10697
BEFORE
AFTER
Once #18487 is merged
Checklist