Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fcs.fs link #18419

Merged
merged 1 commit into from
Mar 27, 2025
Merged

Fix fcs.fs link #18419

merged 1 commit into from
Mar 27, 2025

Conversation

MangelMaxime
Copy link
Contributor

Description

Fix 404 link when clicking on fcs.fs.

I am unsure, if use a relative path is better than a full URL like: https://github.com/dotnet/fsharp/blob/main/src/Compiler/Driver/fsc.fs or better with the commit hash for it to be permanent.

Fixes # (issue, if applicable)

Checklist

  • Test cases added

  • Performance benchmarks added in case of performance changes

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/release-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

@MangelMaxime MangelMaxime requested a review from a team as a code owner March 27, 2025 09:07
Copy link
Contributor

✅ No release notes required

Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, thanks!

No need for a permalink I think, we don't move these parts often...

@psfinaki psfinaki merged commit a3181c4 into dotnet:main Mar 27, 2025
4 checks passed
@MangelMaxime MangelMaxime deleted the patch-2 branch March 27, 2025 13:07
@MangelMaxime
Copy link
Contributor Author

The permalink suggestion was because it seems like the docs folder is a F# Formatting website or something like.

If the docs is published somewhere or even locally served, I am not sure if the link will still works.

But fixing the link is already good enough I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants