Bugfix :: Nullness :: Add warnings for instantiations of (T|null) which are not allowed in F# (frequent at Deserialize from S.T.Json) #18057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble-generic-return-type-used-with-anonymous-record
Closed
7 tasks
❗ Release notes required
|
Co-authored-by: Vlad Zarytovskii <[email protected]>
…ble-generic-return-type-used-with-anonymous-record
0101
approved these changes
Nov 29, 2024
…ble-generic-return-type-used-with-anonymous-record
psfinaki
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a missing waring in case of disallowed generic instantiations for code in C# that uses (T|null) for uncostrained generic, therefore making it possible to make
|nullout of tuples, anons, structs or units of measure.These types cannot carry a nullness information at the type system level in F#, and therefore subsequent checks for nullness stop working.
This PR adds a warning when such method is used with a type disallowing nullness qualifier.
Fixes #17951