Fix null dereference build errors in the scaffolding tests - #38949
Merged
Merged
Conversation
FindEntityType returns a nullable IEntityType, and three call sites added in dotnet#38795 dereference the result directly. The test projects build with warnings as errors, so this fails the build instead of just warning, and it currently takes down the Main leg of CI on all three platforms. Every other FindEntityType call in these two files already uses the null forgiving operator for this exact pattern, so match that.
AndriySvyryd
approved these changes
Sep 10, 2026
AndriySvyryd
left a comment
AndriySvyryd
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EFCore.Design.Testscurrently fails to build on main, which takes theMainleg of CI down on all three platforms:FindEntityTypereturns a nullableIEntityType, and the three call sites added in #38795 dereference the result directly. The test projects build with warnings as errors, so this fails the build rather than just warning.Every other
FindEntityTypecall in these two files already uses the null forgiving operator for exactly this pattern (for example lines 247, 299 and 390 ofCSharpDbContextGeneratorTest.cs), so this change just makes the new call sites consistent with the ones around them.Verified locally on Linux:
EFCore.Design.Testsbuilds clean and the three affected tests pass.