Handle NaN and Infinity in CSharpHelper.Literal(float) - #38696
Merged
AndriySvyryd merged 1 commit intoSep 10, 2026
Merged
Conversation
- Return float.NaN, float.PositiveInfinity, and float.NegativeInfinity instead of invalid literals such as "NaNf", "Infinityf", and "-Infinityf" that do not compile - Mirrors the existing NaN/Infinity handling for double - Add float NaN/Infinity cases to CSharpHelperTest.Literal_works Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes C# code generation for float literals in CSharpHelper by emitting valid, compilable expressions for NaN and infinities (matching the existing behavior for double).
Changes:
- Update
CSharpHelper.Literal(float)to returnfloat.NaN,float.PositiveInfinity, andfloat.NegativeInfinityfor the corresponding special values. - Add test coverage for these
floatspecial cases inCSharpHelperTest.Literal_works.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/EFCore.Design.Tests/Design/Internal/CSharpHelperTest.cs | Adds float NaN/Infinity InlineData cases to validate the new literal formatting. |
| src/EFCore.Design/Design/Internal/CSharpHelper.cs | Implements special-case handling for float NaN/Infinity to avoid emitting invalid literals like NaNf/Infinityf. |
Contributor
Author
|
@dotnet-policy-service agree |
AndriySvyryd
approved these changes
Sep 10, 2026
AndriySvyryd
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution!
This was referenced Sep 10, 2026
AndriySvyryd
pushed a commit
that referenced
this pull request
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.