Skip to content

add missing return value #2314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 18, 2019
Merged

add missing return value #2314

merged 6 commits into from
Apr 18, 2019

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Apr 16, 2019

No description provided.

@mairaw mairaw added this to the April 2019 milestone Apr 16, 2019
@mairaw mairaw self-assigned this Apr 16, 2019
rpetrusha
rpetrusha approved these changes Apr 16, 2019
View reviewed changes
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @mairaw. I've left a couple of suggested changes, one unrelated to your PR.

@mairaw mairaw merged commit 7668d4b into master Apr 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the mairaw-patch-2 branch April 18, 2019 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@mairaw mairaw

Labels
None yet
Projects
None yet
Milestone
April 2019
Development

Successfully merging this pull request may close these issues.
2 participants
@mairaw @rpetrusha