-
Notifications
You must be signed in to change notification settings - Fork 6k
Document MTP v1 to v2 migration #48673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Support for target frameworks .NET Core 3.1 to .NET 7 is dropped. The minimum supported .NET version is .NET 8. | ||
This change doesn't affect .NET Framework. .NET Framework 4.6.2 continues to be the minimum supported .NET Framework target. | ||
|
||
### Remove obsolete types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Remove obsolete types | |
### Removed obsolete types |
1. VSTest-based implementation: this was the only implementation up to .NET 9 SDK. | ||
2. MTP-based implementation: this was added starting in .NET 10 SDK. | ||
|
||
Running MTP test projects with .NET 10 SDK now requires opting-in to the MTP-based `dotnet test` and can no longer be run with the VSTest-based implementation, which was previously enabled by `TestingPlatformDotnetTestSupport` MSBuild property in MTP v1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to describe this in more actionable way.
Running MTP test projects with .NET 10 SDK now requires opting-in to the MTP-based `dotnet test` and can no longer be run with the VSTest-based implementation, which was previously enabled by `TestingPlatformDotnetTestSupport` MSBuild property in MTP v1. | |
Running MTP test projects with .NET 10 SDK now requires opting-in to the MTP-based `dotnet test` by: | |
... the global.json config | |
Without this opt-in, dotnet test will fail with this error: | |
`TestingPlatformDotnetTestSupport` MSBuild property is no longer having any effect and can be removed from the project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, recommending to run through copilot yet to polish the stylistics (unless that has been done already).
href: ../../core/testing/unit-testing-mstest-migration-v3-v4.md | ||
- name: Microsoft.Testing.Platform support (MSTest runner) | ||
href: ../../core/testing/unit-testing-mstest-runner-intro.md | ||
- name: Migrate from Microsoft.Testing.Platform v1 to Microsoft.Testing.Platform v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name: Migrate from Microsoft.Testing.Platform v1 to Microsoft.Testing.Platform v2 | |
- name: Migrate from Microsoft.Testing.Platform v1 to v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might make it easier to read.
|
||
### API signature changes | ||
|
||
- A `CancellationToken` parameter was added to `IOutputDevice.DisplayAsync`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use an xref for IOutputDevice.DisplayAsync?? There's a VS Code extension you can install to help with xrefs.
Internal previews