Skip to content

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Sep 23, 2025

@Youssef1313 Youssef1313 requested review from IEvangelist and a team as code owners September 23, 2025 14:09
@dotnetrepoman dotnetrepoman bot added this to the September 2025 milestone Sep 23, 2025
@Youssef1313 Youssef1313 requested review from Evangelink, nohwnd and gewarren and removed request for a team and IEvangelist September 23, 2025 14:09
Support for target frameworks .NET Core 3.1 to .NET 7 is dropped. The minimum supported .NET version is .NET 8.
This change doesn't affect .NET Framework. .NET Framework 4.6.2 continues to be the minimum supported .NET Framework target.

### Remove obsolete types
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Remove obsolete types
### Removed obsolete types

1. VSTest-based implementation: this was the only implementation up to .NET 9 SDK.
2. MTP-based implementation: this was added starting in .NET 10 SDK.

Running MTP test projects with .NET 10 SDK now requires opting-in to the MTP-based `dotnet test` and can no longer be run with the VSTest-based implementation, which was previously enabled by `TestingPlatformDotnetTestSupport` MSBuild property in MTP v1.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to describe this in more actionable way.

Suggested change
Running MTP test projects with .NET 10 SDK now requires opting-in to the MTP-based `dotnet test` and can no longer be run with the VSTest-based implementation, which was previously enabled by `TestingPlatformDotnetTestSupport` MSBuild property in MTP v1.
Running MTP test projects with .NET 10 SDK now requires opting-in to the MTP-based `dotnet test` by:
... the global.json config
Without this opt-in, dotnet test will fail with this error:
`TestingPlatformDotnetTestSupport` MSBuild property is no longer having any effect and can be removed from the project.

Copy link
Member

@tkapin tkapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, recommending to run through copilot yet to polish the stylistics (unless that has been done already).

href: ../../core/testing/unit-testing-mstest-migration-v3-v4.md
- name: Microsoft.Testing.Platform support (MSTest runner)
href: ../../core/testing/unit-testing-mstest-runner-intro.md
- name: Migrate from Microsoft.Testing.Platform v1 to Microsoft.Testing.Platform v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Migrate from Microsoft.Testing.Platform v1 to Microsoft.Testing.Platform v2
- name: Migrate from Microsoft.Testing.Platform v1 to v2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might make it easier to read.


### API signature changes

- A `CancellationToken` parameter was added to `IOutputDevice.DisplayAsync`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use an xref for IOutputDevice.DisplayAsync?? There's a VS Code extension you can install to help with xrefs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants