-
Notifications
You must be signed in to change notification settings - Fork 6k
Corrections to the mage.exe page #45836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gewarren
approved these changes
Apr 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BartoszKlonowski
docs/framework/tools/mage-exe-manifest-generation-and-editing-tool.md
Outdated
Show resolved
Hide resolved
docs/framework/tools/mage-exe-manifest-generation-and-editing-tool.md
Outdated
Show resolved
Hide resolved
gewarren
reviewed
Apr 21, 2025
docs/framework/tools/mage-exe-manifest-generation-and-editing-tool.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Genevieve Warren <[email protected]>
gewarren
reviewed
Apr 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#35326 states only one algorithm is valid for -Sign.
docs/framework/tools/mage-exe-manifest-generation-and-editing-tool.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Genevieve Warren <[email protected]>
gewarren
approved these changes
Apr 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community-contribution
Indicates PR is created by someone from the .NET community.
dotnet-framework/svc
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #35326
It makes necessary corrections to the mage.exe page such as:
-a
option with-Sign
-Sign
commandThose newly added are
-TimestampUri
and-Algorithm
. They are mostly copy-paste from the general table, however, I removed "Use with -update option" statement fromAlgorithm
, since I couldn't see that requirement when applying in-Sign
context.Internal previews