Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give more context about dotnet test with mtp #44618

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Give more context about dotnet test with mtp #44618

merged 2 commits into from
Jan 31, 2025

Conversation

Evangelink
Copy link
Member

@Evangelink Evangelink commented Jan 30, 2025 •
edited by github-actions bot
Loading

@Evangelink Evangelink requested review from IEvangelist and a team as code owners January 30, 2025 14:22
@dotnetrepoman dotnetrepoman bot added this to the January 2025 milestone Jan 30, 2025
@Evangelink Evangelink enabled auto-merge (squash) January 30, 2025 14:31
BillWagner
BillWagner approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @Evangelink

I had one grammar suggestion, and then I'll :shipit:

@BillWagner BillWagner disabled auto-merge January 31, 2025 14:08
@Evangelink
Copy link
Member Author

Thanks @BillWagner. LGTM, can we merge?

@BillWagner BillWagner merged commit 1d4e0e6 into dotnet:main Jan 31, 2025
8 checks passed
@Evangelink Evangelink deleted the dotnet-test-mtp branch January 31, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@Youssef1313 Youssef1313 Youssef1313 approved these changes

@IEvangelist IEvangelist Awaiting requested review from IEvangelist IEvangelist is a code owner

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
January 2025
Development

Successfully merging this pull request may close these issues.
3 participants
@Evangelink @BillWagner @Youssef1313