Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Tip section in CA2208 page #44490

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

BartoszKlonowski
Copy link
Contributor

@BartoszKlonowski BartoszKlonowski commented Jan 22, 2025

This pull request fixes #44030
It updates the tip in the CA2208 page by:

  • updating the screenshot of a tooltip for argument swap
    It was already outdated and was showing an incorrect order of parameters as a potential fix of the rule
  • removing the second part of the tip
    The second part was showing the tooltip that was for the single argument being the type name. This is outdated, as there is already the possibility to pass a single argument to one of ArgumentNullException overloads.

Please see the issue comments for more details.


Internal previews

📄 File 🔗 Preview link
docs/fundamentals/code-analysis/quality-rules/ca2208.md CA2208: Instantiate argument exceptions correctly

@BartoszKlonowski BartoszKlonowski requested review from gewarren and a team as code owners January 22, 2025 22:47
@dotnet-policy-service dotnet-policy-service bot added dotnet-fundamentals/svc community-contribution Indicates PR is created by someone from the .NET community. labels Jan 22, 2025
@gewarren
Copy link
Contributor

Please see comments I put in the issue and let me know your thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The proposed fix for CA2208 is not consistent in the doc
2 participants