Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update override-windows-sdk-package-version.md #44445

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

LegendaryBlair
Copy link
Contributor

@LegendaryBlair LegendaryBlair commented Jan 20, 2025

Summary

Add a section to talk about the usage when working with WindowsAppSDK

  1. When to add this property.
  2. When to remove this property once the issue is resolved.

Internal previews

📄 File 🔗 Preview link
docs/core/compatibility/sdk/5.0/override-windows-sdk-package-version.md FrameworkReference replaced with WindowsSdkPackageVersion for Windows SDK

Add a section to talk about when to add / remove this property when working with WindowsAppSDK
@LegendaryBlair LegendaryBlair requested review from CamSoper, gewarren and a team as code owners January 20, 2025 09:00
@dotnetrepoman dotnetrepoman bot added this to the January 2025 milestone Jan 20, 2025
@dotnet-policy-service dotnet-policy-service bot added dotnet-fundamentals/svc community-contribution Indicates PR is created by someone from the .NET community. labels Jan 20, 2025
Copy link
Contributor

@CamSoper CamSoper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gewarren any issues with me merging?

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

…ersion.md


accept the suggestion

Co-authored-by: Genevieve Warren <[email protected]>
@gewarren gewarren enabled auto-merge (squash) January 23, 2025 04:14
@gewarren gewarren merged commit d9474fb into dotnet:main Jan 23, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants