Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependencies in linux-alpine.md #44113

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Conversation

DaRosenberg
Copy link
Contributor

@DaRosenberg DaRosenberg commented Dec 30, 2024

Summary

This commit adds icu-libs and icu-data-full to the list of required dependencies on Alpine. There are required unless the app is running in globalization-invariant mode.

See https://wiki.alpinelinux.org/wiki/Release_Notes_for_Alpine_3.16.0#ICU_data_split for more information about why both those packages need to be mentioned.


Internal previews

📄 File 🔗 Preview link
docs/core/install/linux-alpine.md Install the .NET SDK or the .NET Runtime on Alpine

This commit adds icu-libs and icu-data-full to the list of required dependencies on Alpine. There are required unless the app is running in globalization-invariant mode.

See https://wiki.alpinelinux.org/wiki/Release_Notes_for_Alpine_3.16.0#ICU_data_split for more information about why both those packages need to be mentioned.
@DaRosenberg DaRosenberg requested review from adegeo and a team as code owners December 30, 2024 11:31
@dotnetrepoman dotnetrepoman bot added this to the December 2024 milestone Dec 30, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label Dec 30, 2024
Copy link
Contributor

@adegeo adegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch for this fix!

@adegeo adegeo enabled auto-merge (squash) December 31, 2024 18:44
@adegeo adegeo merged commit 05a52e8 into dotnet:main Dec 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc install/subsvc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants