Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TimeProvider overview #43881

Merged
merged 8 commits into from
Dec 10, 2024
Merged

Add TimeProvider overview #43881

merged 8 commits into from
Dec 10, 2024

Conversation

adegeo
Copy link
Contributor

@adegeo adegeo commented Dec 6, 2024 •
edited by github-actions bot
Loading

@adegeo adegeo requested a review from a team as a code owner December 6, 2024 00:07
@dotnetrepoman dotnetrepoman bot added this to the December 2024 milestone Dec 6, 2024
@adegeo adegeo requested review from IEvangelist and tarekgh December 6, 2024 00:08
@tarekgh
Copy link
Member

tarekgh commented Dec 6, 2024

@adegeo I'll try to review this PR when I get a chance. Sorry for the delay.

@adegeo
Copy link
Contributor Author

adegeo commented Dec 6, 2024

@tarekgh It's been 1 day! Don't worry! 😆

tarekgh
tarekgh approved these changes Dec 7, 2024
View reviewed changes
Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adegeo for writing the doc.

I added a few comments and suggestions if you want to consider it. LGTM otherwise. I am going to be off so don't need to block on my review :-)

@adegeo adegeo enabled auto-merge (squash) December 10, 2024 18:49
@adegeo adegeo merged commit 726a000 into main Dec 10, 2024
8 checks passed
@adegeo adegeo deleted the adegeo/timeprovider-41650 branch December 10, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarekgh tarekgh tarekgh approved these changes

@IEvangelist IEvangelist IEvangelist approved these changes

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
December 2024
Development

Successfully merging this pull request may close these issues.

Document the TimeProvider class
3 participants
@adegeo @tarekgh @IEvangelist