Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WebClient references to HttpClient in F# asynchronous programming documentation #43794

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Update WebClient references to HttpClient in F# asynchronous programming documentation #43794

merged 2 commits into from
Dec 2, 2024

Conversation

shethaadit
Copy link
Contributor

@shethaadit shethaadit commented Nov 28, 2024 •
edited by github-actions bot
Loading

Summary

This PR addresses outdated references to WebClient in the F# asynchronous programming documentation. The sample code was updated in PR #43626 to use HttpClient with GetStringAsync, but the accompanying text still mentions WebClient.AsyncDownloadString.

Changes include:

  • Replacing references to WebClient.AsyncDownloadString with HttpClient.GetStringAsync (wrapped with Async.AwaitTask for F# compatibility).
  • Updating the description to reflect the modernized approach using HttpClient.

These updates ensure consistency between the code sample and the explanatory text, improving the clarity and accuracy of the documentation.

Fixes #43744

Internal previews

📄 File 🔗 Preview link
docs/fsharp/language-reference/async-expressions.md Async expressions

@dotnetrepoman dotnetrepoman bot added this to the November 2024 milestone Nov 28, 2024
@dotnet-policy-service dotnet-policy-service bot added okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings. community-contribution Indicates PR is created by someone from the .NET community. labels Nov 28, 2024
psfinaki
psfinaki approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Adit for updating F# docs :)

BillWagner
BillWagner approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BillWagner BillWagner merged commit 6878d72 into dotnet:main Dec 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psfinaki psfinaki psfinaki approved these changes

@vzarytovskii vzarytovskii vzarytovskii approved these changes

@BillWagner BillWagner BillWagner approved these changes

@KathleenDollard KathleenDollard Awaiting requested review from KathleenDollard KathleenDollard is a code owner

Assignees
No one assigned
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fsharp/svc okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings.
Projects
None yet
Milestone
November 2024
Development

Successfully merging this pull request may close these issues.

The article reference WebClient while the sample has been updated to use HttpClient
4 participants
@shethaadit @BillWagner @vzarytovskii @psfinaki