Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resilient HTTP apps] Add a paragraph describing how to disable retries for some HTTP methods #43630

Merged
merged 6 commits into from
Jan 23, 2025

Conversation

iliar-turdushev
Copy link
Contributor

@iliar-turdushev iliar-turdushev commented Nov 18, 2024

The PR adds description how to disable retries for some HTTP methods.

Fixes dotnet/extensions#5248


Internal previews

📄 File 🔗 Preview link
docs/core/resilience/http-resilience.md Build resilient HTTP apps: Key development patterns

Adds description how to disable retries for some HTTP methods
@iliar-turdushev
Copy link
Contributor Author

The API described in the PR will be released in dotnet/extensions 9.1.0 (https://github.com/dotnet/extensions). We want to merge the PR only after that release.

@eduherminio eduherminio self-requested a review November 19, 2024 11:25
Copy link

@dariusclay dariusclay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions but will leave it up to @IEvangelist to confirm

docs/core/resilience/http-resilience.md Outdated Show resolved Hide resolved
docs/core/resilience/http-resilience.md Outdated Show resolved Hide resolved
docs/core/resilience/http-resilience.md Outdated Show resolved Hide resolved
Co-authored-by: Darius Letterman <[email protected]>
@IEvangelist IEvangelist added blocked Blocked for some reason DO NOT MERGE labels Nov 20, 2024
@IEvangelist
Copy link
Member

Added the DO NOT MERGE label, while this is approved and looks good, we're currently blocked as the corresponding NuGet package version isn't available yet.

@BillWagner BillWagner closed this Jan 14, 2025
@BillWagner BillWagner reopened this Jan 14, 2025
@dotnetrepoman dotnetrepoman bot modified the milestones: November 2024, January 2025 Jan 14, 2025
@iliar-turdushev
Copy link
Contributor Author

Added the DO NOT MERGE label, while this is approved and looks good, we're currently blocked as the corresponding NuGet package version isn't available yet.

The package with the new API was published in .NET Extensions 9.1.0. But the API reference documentation (like the following one) doesn't still include the new API, and because of that the build is failing. @IEvangelist @RussKie do you know when the new API reference documentation will be published? Thank you.

@IEvangelist
Copy link
Member

Added the DO NOT MERGE label, while this is approved and looks good, we're currently blocked as the corresponding NuGet package version isn't available yet.

The package with the new API was published in .NET Extensions 9.1.0. But the API reference documentation (like the following one) doesn't still include the new API, and because of that the build is failing. @IEvangelist @RussKie do you know when the new API reference documentation will be published? Thank you.

If the new NuGet package is live/public, we should just need to kick off a new .NET API docs build. I believe @gewarren will know best, so I'll defer to her.

@gewarren
Copy link
Contributor

I can work on updating the API docs today.

@iliar-turdushev
Copy link
Contributor Author

I can work on updating the API docs today.

@gewarren Thank you. Do you need any information from my side?

@gewarren
Copy link
Contributor

@gewarren Thank you. Do you need any information from my side?

No, all good. The job is running and will be done in about 2.5 hours.

@gewarren
Copy link
Contributor

APIs added in dotnet/dotnet-api-docs#10864.

@gewarren gewarren closed this Jan 23, 2025
@gewarren gewarren reopened this Jan 23, 2025
docs/core/resilience/http-resilience.md Outdated Show resolved Hide resolved
docs/core/resilience/http-resilience.md Outdated Show resolved Hide resolved
@gewarren gewarren merged commit d31b6fd into dotnet:main Jan 23, 2025
8 checks passed
@iliar-turdushev
Copy link
Contributor Author

@gewarren Thank you very much for taking care of this PR.

@iliar-turdushev iliar-turdushev deleted the httpresilience-retryoptions branch January 23, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix default HTTP resilience not to retry non-idempotent requests (POST, PUT, etc.)
8 participants