Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slight clarification about IsTrimmable metadata #42317

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Aug 23, 2024

I don't think we want to say much about [AssemblyMetadata("IsTrimmable", "True")] since most users should just opt in via the MSBuild options. This adds a minor note to a mention of the assembly metadata to prevent confusion.
Fixes #30790


Internal previews

📄 File 🔗 Preview link
docs/core/deploying/trimming/trimming-options.md docs/core/deploying/trimming/trimming-options

@sbomer sbomer requested a review from a team August 23, 2024 19:24
@sbomer sbomer requested review from adegeo and a team as code owners August 23, 2024 19:24
@dotnet-bot dotnet-bot added this to the August 2024 milestone Aug 23, 2024
@sbomer sbomer merged commit aac556b into dotnet:main Aug 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify IsTrimmable assembly metadata
3 participants