Skip to content

SFI - ROPC: Clean up adonet files #42289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 22, 2024
Merged

SFI - ROPC: Clean up adonet files #42289

merged 4 commits into from
Aug 22, 2024

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Aug 21, 2024

Contributes to #41954.

(Hide whitespace changes.)

  • Removes connection strings where not needed.
  • Adds note about using managed identities where appropriate.
  • Delete ms.assetid metadata.
  • Improves descriptions to placate Learn Linter.
  • Fix headings by using sentence case and replacing gerunds.

Internal previews

Toggle expand/collapse
📄 File 🔗 Preview link
docs/framework/data/adonet/asynchronous-programming.md docs/framework/data/adonet/asynchronous-programming
docs/framework/data/adonet/code-access-security.md docs/framework/data/adonet/code-access-security
docs/framework/data/adonet/connection-string-builders.md docs/framework/data/adonet/connection-string-builders
docs/framework/data/adonet/connection-string-syntax.md docs/framework/data/adonet/connection-string-syntax
docs/framework/data/adonet/connection-strings-and-configuration-files.md docs/framework/data/adonet/connection-strings-and-configuration-files
docs/framework/data/adonet/connection-strings.md docs/framework/data/adonet/connection-strings
docs/framework/data/adonet/data-providers.md docs/framework/data/adonet/data-providers
docs/framework/data/adonet/dataset-datatable-dataview/creating-a-datatable-from-a-dataview.md docs/framework/data/adonet/dataset-datatable-dataview/creating-a-datatable-from-a-dataview
docs/framework/data/adonet/dataset-datatable-dataview/the-load-method.md docs/framework/data/adonet/dataset-datatable-dataview/the-load-method
docs/framework/data/adonet/distributed-transactions.md docs/framework/data/adonet/distributed-transactions
docs/framework/data/adonet/establishing-the-connection.md docs/framework/data/adonet/establishing-the-connection
docs/framework/data/adonet/filling-a-dataset-using-one-or-more-ref-cursors.md docs/framework/data/adonet/filling-a-dataset-using-one-or-more-ref-cursors
docs/framework/data/adonet/getschema-and-schema-collections.md docs/framework/data/adonet/getschema-and-schema-collections
docs/framework/data/adonet/how-to-bind-a-dataview-object-to-a-winforms-datagridview-control.md docs/framework/data/adonet/how-to-bind-a-dataview-object-to-a-winforms-datagridview-control
docs/framework/data/adonet/obtaining-a-dbproviderfactory.md docs/framework/data/adonet/obtaining-a-dbproviderfactory
docs/framework/data/adonet/ole-db-odbc-and-oracle-connection-pooling.md docs/framework/data/adonet/ole-db-odbc-and-oracle-connection-pooling
docs/framework/data/adonet/oracle-sequences.md docs/framework/data/adonet/oracle-sequences
docs/framework/data/adonet/oracletypes.md docs/framework/data/adonet/oracletypes
docs/framework/data/adonet/performance-counters.md docs/framework/data/adonet/performance-counters
docs/framework/data/adonet/performing-batch-operations-using-dataadapters.md docs/framework/data/adonet/performing-batch-operations-using-dataadapters
docs/framework/data/adonet/protecting-connection-information.md docs/framework/data/adonet/protecting-connection-information
docs/framework/data/adonet/ref-cursor-parameters-in-an-oracledatareader.md docs/framework/data/adonet/ref-cursor-parameters-in-an-oracledatareader
docs/framework/data/adonet/retrieving-data-from-multiple-ref-cursors.md docs/framework/data/adonet/retrieving-data-from-multiple-ref-cursors
docs/framework/data/adonet/retrieving-identity-or-autonumber-values.md docs/framework/data/adonet/retrieving-identity-or-autonumber-values
docs/framework/data/adonet/schema-restrictions.md docs/framework/data/adonet/schema-restrictions
docs/framework/data/adonet/secure-data-access.md docs/framework/data/adonet/secure-data-access
docs/framework/data/adonet/sql-server-connection-pooling.md docs/framework/data/adonet/sql-server-connection-pooling
docs/framework/data/adonet/sqlclient-streaming-support.md docs/framework/data/adonet/sqlclient-streaming-support
docs/framework/data/adonet/system-transactions-integration-with-sql-server.md docs/framework/data/adonet/system-transactions-integration-with-sql-server
docs/framework/data/adonet/whats-new.md docs/framework/data/adonet/whats-new

Note

This table shows preview links for the 30 files with the most changes. For preview links for other files in this PR, select OpenPublishing.Build Details within checks.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM overall.

I found one typo in the code to fix before you merge it.

@gewarren gewarren enabled auto-merge (squash) August 22, 2024 16:24
@gewarren gewarren merged commit 108c1d7 into dotnet:main Aug 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants