Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build warnings #20273

Merged
merged 4 commits into from
Aug 27, 2020
Merged

Fix build warnings #20273

merged 4 commits into from
Aug 27, 2020

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Aug 25, 2020

Fix build warnings introduced by dotnet/machinelearning-samples#839

ML.NET API reference is now broken too, https://docs.microsoft.com/en-us/dotnet/api/microsoft.ml.staticpipe.countfeatureselectorstaticextensions.selectfeaturesbasedoncount?view=ml-dotnet-preview-0.14.0.

All examples shows a warning: "It looks like the sample you are looking for has moved! Rest assured we are working on resolving this."

Preview Link

@Youssef1313
Copy link
Member Author

@luisquintanilla I'm unsure how the API reference should be fixed, I can't find out when/where these files were moved.

Check dotnet/ml-api-docs#142 for the build warnings.

@Youssef1313
Copy link
Member Author

Pinging @luisquintanilla

@luisquintanilla
Copy link
Contributor

@Youssef1313 I think the line numbers may have shifted, so the rendering doesn't look right.

@Youssef1313
Copy link
Member Author

@luisquintanilla I fixed the line numbers, and also other minor fixes.

Copy link
Contributor

@luisquintanilla luisquintanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! That was fast. This looks good to me. Approving

@luisquintanilla luisquintanilla merged commit 0e7444c into dotnet:master Aug 27, 2020
@Youssef1313 Youssef1313 deleted the patch-38 branch August 27, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants