-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The proposed fix for CA2208 is not consistent in the doc #44030
Comments
@gewarren Let me take a look into that and work on it if needed. |
@gewarren Yes, I confirm this is the tooltip that requires an update of the screenshots (the code samples from snippets are correct). |
One more thing: I don't think we will need the second screenshot any longer, as I can see that having single parameter of the type name matches one of the public ArgumentNullException(string? paramName)
: base(SR.ArgumentNull_Generic, paramName)
{
HResult = HResults.E_POINTER;
} |
I believe the doc is actually correct as written. There's a subtle difference here because the parameter order is different between ArgumentException and ArgumentNullException, as noted in the article. Perhaps that part needs to be more prominent? Or maybe we just go ahead and switch the screenshot to the ANE exception. |
This part is also okay as-is. The code fix appears for |
Type of issue
Other (describe below)
Description
[Enter feedback here]
Hi, I'm trying to fix the CA2208 error in my project. But in the official documentation, I found that the fixes are totally different in the tip and the example.
In the
How to fix violations
tip, the parameter name is placed to the 2nd paramenter:But in the
Example
Session, the name is placed to the 1st parameter:From the ArgumentException Constructor (System) | Microsoft Learn the parameter should be in the 2nd parameter.
Page URL
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2208#how-to-fix-violations
Content source URL
https://github.com/dotnet/docs/blob/main/docs/fundamentals/code-analysis/quality-rules/ca2208.md
Document Version Independent Id
cc2b5015-89a9-02ff-a585-fca3449dfa9a
Article author
@gewarren
Metadata
Related Issues
The text was updated successfully, but these errors were encountered: