end to end test with bash script #327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And -$COLUMN cannot work with #293 (comment) script |
wli3
force-pushed
the
bash-auto-complete
branch
from
9dd0dfb to
3360019
Compare
wli3
commented
Nov 28, 2018
| .Should() | ||
| .BeEmpty(); | ||
|
|
||
| // stdOut cannot get echo's result. So it need to write to a file. |
There was a problem hiding this comment.
Help need. If get-completions.sh simply do an echo. stdOut cannot capture that. But testrunner output has it. I cannot make it work so I end up write to a file.
wli3
commented
Nov 28, 2018
| #!/usr/bin/env bash | ||
|
|
||
| echo "hi" | ||
| get_completion_function_name_from_complete_output() |
There was a problem hiding this comment.
@omajid THANKS!!!!! IT WORKS!!!!!!!!!!!
wli3
changed the title
wli3
commented
Nov 28, 2018
| @@ -23,4 +26,13 @@ | |||
| <ProjectReference Include="..\System.CommandLine\System.CommandLine.csproj" /> | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <None Update="dotnet-suggest-shim.bash"> | |||
There was a problem hiding this comment.
We want to add auto copy-paste to bashrc in the future. So I let dotnet suggest carry them now to make it easier to test
|
won't work in CI, let me keep digging |
added 3 commits
December 9, 2018 17:08
Removed part is to format output from one line to multi line. It is not really needed. We should keep bash script as simple as possible.
Let another sh to run auto complete and write result to a file
wli3
force-pushed
the
bash-auto-complete
branch
from
47ba0ce to
ceeff10
Compare
|
cannot repro on mac and ubuntu :( |
|
@dotnet-bot test Ubuntu16.04 Release |
1 similar comment
|
@dotnet-bot test Ubuntu16.04 Release |
added 2 commits
December 16, 2018 15:50
And it also removed the race for generating it
|
time box up for this test. i'll not keep digging this route |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed part is to format output from one line to multi line. It is not really needed.
We should keep bash script as simple as possible. And add end to end test with bash script
fix #293