Provide code analysis rule to detect if constraint is invalid for parameter type #63819
+517
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should address #45218
This PR is adding a new code analysis rule
ASP0029: Invalid constraint for parameter type
for Minimal APIs. The diagnostic should be reported if route constraint cannot be used with the type of the corresponding parameter declared in the route handler, for example:Rule
The following table lists constraints and types they can be used with:
string
bool
System.DateTime
decimal
double
System.Guid
long
,ulong
byte
,sbyte
,short
,ushort
,int
,uint
,long
,ulong
byte
,sbyte
,short
,ushort
,int
,uint
,long
,ulong
byte
,sbyte
,short
,ushort
,int
,uint
,long
,ulong
byte
,sbyte
,short
,ushort
,int
,uint
,long
,ulong
string
string
string
string
string
string
Changes
Added a new rule to
DiagnosticDescriptors.cs
:Augmented
RouteHandlerAnalyzer
with route constraints analysis to check if a constraint specified for route parameter is invalid for the type of the corresponding parameter declared in the route handler.Added unit tests.