Make sure .pdb for AspnetcoreCA gets published to symbol server #63587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-networking
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that debug symbols (.pdb files) for the AspNetCoreCA project are properly published to the symbol server by copying them to the symbols output directory. This should resolve APIScan bugs by making the symbols available for Arcade's symbol indexing process.
Key changes:
- Adds a custom MSBuild target to copy .pdb files to the symbols output path
- Creates two copies with different naming conventions to ensure compatibility
src/Installers/Windows/AspNetCoreModule-Setup/CustomAction/aspnetcoreCA.vcxproj
Outdated
Show resolved
Hide resolved
…netcoreCA.vcxproj Co-authored-by: Copilot <[email protected]>
danmoseley
approved these changes
Sep 8, 2025
mmitche
reviewed
Sep 8, 2025
src/Installers/Windows/AspNetCoreModule-Setup/CustomAction/aspnetcoreCA.vcxproj
Outdated
Show resolved
Hide resolved
joeloff
approved these changes
Sep 8, 2025
|
/backport to release/10.0 |
|
Started backporting to release/10.0: https://github.com/dotnet/aspnetcore/actions/runs/17564195890 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix some APIScan bugs. Anything in the symbol output dir gets indexed by Arcade:
aspnetcore/eng/Publishing.props
Line 20 in 178dda5
CC @danmoseley