Skip to content

[main] Source code updates from dotnet/dotnet #62664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jul 10, 2025

Note

This is a codeflow update. It may contain both source code changes from the VMR as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/dotnet

Updated Dependencies

  • From 10.0.0-preview.7.25358.102 to 10.0.0-preview.7.25365.101
    • dotnet-ef
    • Microsoft.Bcl.AsyncInterfaces
    • Microsoft.Bcl.TimeProvider
    • Microsoft.EntityFrameworkCore
    • Microsoft.EntityFrameworkCore.Design
    • Microsoft.EntityFrameworkCore.InMemory
    • Microsoft.EntityFrameworkCore.Relational
    • Microsoft.EntityFrameworkCore.Sqlite
    • Microsoft.EntityFrameworkCore.SqlServer
    • Microsoft.EntityFrameworkCore.Tools
    • Microsoft.Extensions.Caching.Abstractions
    • Microsoft.Extensions.Caching.Memory
    • Microsoft.Extensions.Configuration
    • Microsoft.Extensions.Configuration.Abstractions
    • Microsoft.Extensions.Configuration.Binder
    • Microsoft.Extensions.Configuration.CommandLine
    • Microsoft.Extensions.Configuration.EnvironmentVariables
    • Microsoft.Extensions.Configuration.FileExtensions
    • Microsoft.Extensions.Configuration.Ini
    • Microsoft.Extensions.Configuration.Json
    • Microsoft.Extensions.Configuration.UserSecrets
    • Microsoft.Extensions.Configuration.Xml
    • Microsoft.Extensions.DependencyInjection
    • Microsoft.Extensions.DependencyInjection.Abstractions
    • Microsoft.Extensions.DependencyModel
    • Microsoft.Extensions.Diagnostics
    • Microsoft.Extensions.Diagnostics.Abstractions
    • Microsoft.Extensions.FileProviders.Abstractions
    • Microsoft.Extensions.FileProviders.Composite
    • Microsoft.Extensions.FileProviders.Physical
    • Microsoft.Extensions.FileSystemGlobbing
    • Microsoft.Extensions.HostFactoryResolver.Sources
    • Microsoft.Extensions.Hosting
    • Microsoft.Extensions.Hosting.Abstractions
    • Microsoft.Extensions.Http
    • Microsoft.Extensions.Logging
    • Microsoft.Extensions.Logging.Abstractions
    • Microsoft.Extensions.Logging.Configuration
    • Microsoft.Extensions.Logging.Console
    • Microsoft.Extensions.Logging.Debug
    • Microsoft.Extensions.Logging.EventLog
    • Microsoft.Extensions.Logging.EventSource
    • Microsoft.Extensions.Logging.TraceSource
    • Microsoft.Extensions.Options
    • Microsoft.Extensions.Options.ConfigurationExtensions
    • Microsoft.Extensions.Options.DataAnnotations
    • Microsoft.Extensions.Primitives
    • Microsoft.Internal.Runtime.AspNetCore.Transport
    • Microsoft.NET.Runtime.MonoAOTCompiler.Task
    • Microsoft.NET.Runtime.WebAssembly.Sdk
    • Microsoft.NETCore.App.Ref
    • Microsoft.NETCore.BrowserDebugHost.Transport
    • Microsoft.NETCore.Platforms
    • System.Collections.Immutable
    • System.Composition
    • System.Configuration.ConfigurationManager
    • System.Diagnostics.DiagnosticSource
    • System.Diagnostics.EventLog
    • System.Diagnostics.PerformanceCounter
    • System.DirectoryServices.Protocols
    • System.Formats.Asn1
    • System.Formats.Cbor
    • System.IO.Hashing
    • System.IO.Pipelines
    • System.Memory.Data
    • System.Net.Http.Json
    • System.Net.Http.WinHttpHandler
    • System.Net.ServerSentEvents
    • System.Numerics.Tensors
    • System.Reflection.Metadata
    • System.Resources.Extensions
    • System.Runtime.Caching
    • System.Security.Cryptography.Pkcs
    • System.Security.Cryptography.Xml
    • System.Security.Permissions
    • System.ServiceProcess.ServiceController
    • System.Text.Encodings.Web
    • System.Text.Json
    • System.Threading.AccessControl
    • System.Threading.Channels
    • System.Threading.RateLimiting
  • From 3.2.0-preview.25358.102 to 3.2.0-preview.25365.101
    • Microsoft.Web.Xdt
  • From 10.0.100-preview.7.25358.102 to 10.0.100-preview.7.25365.101
    • Microsoft.DotNet.HotReload.Agent
    • Microsoft.DotNet.HotReload.Agent.Data
  • From 10.0.0-beta.25358.102 to 10.0.0-beta.25365.101
    • Microsoft.DotNet.Arcade.Sdk
    • Microsoft.DotNet.Build.Tasks.Archives
    • Microsoft.DotNet.Build.Tasks.Installers
    • Microsoft.DotNet.Build.Tasks.Templating
    • Microsoft.DotNet.Helix.Sdk
    • Microsoft.DotNet.RemoteExecutor
    • Microsoft.DotNet.SharedFramework.Sdk
  • From 17.12.36 to 17.15.0-preview-25365-101
    • Microsoft.Build
    • Microsoft.Build.Framework
    • Microsoft.Build.Tasks.Core
    • Microsoft.Build.Utilities.Core

Associated changes in source repos

Updated Dependencies:
dotnet-ef, Microsoft.EntityFrameworkCore.InMemory, Microsoft.EntityFrameworkCore.Relational, Microsoft.EntityFrameworkCore.Sqlite, Microsoft.EntityFrameworkCore.SqlServer, Microsoft.EntityFrameworkCore.Tools, Microsoft.EntityFrameworkCore, Microsoft.EntityFrameworkCore.Design, Microsoft.Extensions.Caching.Abstractions, Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.Binder, Microsoft.Extensions.Configuration.CommandLine, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.FileExtensions, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.Configuration.UserSecrets, Microsoft.Extensions.Configuration.Xml, Microsoft.Extensions.Configuration, Microsoft.Extensions.DependencyInjection.Abstractions, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.Diagnostics, Microsoft.Extensions.Diagnostics.Abstractions, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Composite, Microsoft.Extensions.FileProviders.Physical, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Extensions.Hosting.Abstractions, Microsoft.Extensions.Hosting, Microsoft.Extensions.Http, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Configuration, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.Logging.Debug, Microsoft.Extensions.Logging.EventSource, Microsoft.Extensions.Logging.EventLog, Microsoft.Extensions.Logging.TraceSource, Microsoft.Extensions.Logging, Microsoft.Extensions.Options.ConfigurationExtensions, Microsoft.Extensions.Options.DataAnnotations, Microsoft.Extensions.Options, Microsoft.Extensions.Primitives, Microsoft.Internal.Runtime.AspNetCore.Transport, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Diagnostics.EventLog, System.DirectoryServices.Protocols, System.Formats.Asn1, System.Formats.Cbor, System.IO.Pipelines, System.Net.Http.Json, System.Net.Http.WinHttpHandler, System.Net.ServerSentEvents, System.Reflection.Metadata, System.Resources.Extensions, System.Security.Cryptography.Pkcs, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encodings.Web, System.Text.Json, System.Threading.AccessControl, System.Threading.Channels, System.Threading.RateLimiting, Microsoft.Extensions.DependencyModel, Microsoft.NETCore.App.Ref, Microsoft.NET.Runtime.MonoAOTCompiler.Task, Microsoft.NET.Runtime.WebAssembly.Sdk, Microsoft.Bcl.AsyncInterfaces, Microsoft.Bcl.TimeProvider, System.Collections.Immutable, System.Diagnostics.PerformanceCounter, System.IO.Hashing, System.Memory.Data, System.Numerics.Tensors, System.Runtime.Caching, Microsoft.NETCore.BrowserDebugHost.Transport, System.Composition, Microsoft.NETCore.Platforms (Version 10.0.0-preview.7.25358.102 -> 10.0.0-preview.7.25359.101)
Microsoft.Web.Xdt (Version 3.2.0-preview.25358.102 -> 3.2.0-preview.25359.101)
Microsoft.DotNet.HotReload.Agent, Microsoft.DotNet.HotReload.Agent.Data (Version 10.0.100-preview.7.25358.102 -> 10.0.100-preview.7.25359.101)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk (Version 10.0.0-beta.25358.102 -> 10.0.0-beta.25359.101)
Microsoft.Build, Microsoft.Build.Framework, Microsoft.Build.Tasks.Core, Microsoft.Build.Utilities.Core (Version 17.12.36 -> 17.15.0-preview-25359-101)
@dotnet-maestro dotnet-maestro bot requested review from wtgodbe and a team as code owners July 10, 2025 16:51
@github-actions github-actions bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jul 10, 2025
Copy link
Contributor

@dotnet-policy-service dotnet-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

dotnet-maestro bot and others added 2 commits July 11, 2025 02:03
Updated Dependencies:
dotnet-ef, Microsoft.EntityFrameworkCore.InMemory, Microsoft.EntityFrameworkCore.Relational, Microsoft.EntityFrameworkCore.Sqlite, Microsoft.EntityFrameworkCore.SqlServer, Microsoft.EntityFrameworkCore.Tools, Microsoft.EntityFrameworkCore, Microsoft.EntityFrameworkCore.Design, Microsoft.Extensions.Caching.Abstractions, Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.Binder, Microsoft.Extensions.Configuration.CommandLine, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.FileExtensions, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.Configuration.UserSecrets, Microsoft.Extensions.Configuration.Xml, Microsoft.Extensions.Configuration, Microsoft.Extensions.DependencyInjection.Abstractions, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.Diagnostics, Microsoft.Extensions.Diagnostics.Abstractions, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Composite, Microsoft.Extensions.FileProviders.Physical, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Extensions.Hosting.Abstractions, Microsoft.Extensions.Hosting, Microsoft.Extensions.Http, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Configuration, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.Logging.Debug, Microsoft.Extensions.Logging.EventSource, Microsoft.Extensions.Logging.EventLog, Microsoft.Extensions.Logging.TraceSource, Microsoft.Extensions.Logging, Microsoft.Extensions.Options.ConfigurationExtensions, Microsoft.Extensions.Options.DataAnnotations, Microsoft.Extensions.Options, Microsoft.Extensions.Primitives, Microsoft.Internal.Runtime.AspNetCore.Transport, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Diagnostics.EventLog, System.DirectoryServices.Protocols, System.Formats.Asn1, System.Formats.Cbor, System.IO.Pipelines, System.Net.Http.Json, System.Net.Http.WinHttpHandler, System.Net.ServerSentEvents, System.Reflection.Metadata, System.Resources.Extensions, System.Security.Cryptography.Pkcs, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encodings.Web, System.Text.Json, System.Threading.AccessControl, System.Threading.Channels, System.Threading.RateLimiting, Microsoft.Extensions.DependencyModel, Microsoft.NETCore.App.Ref, Microsoft.NET.Runtime.MonoAOTCompiler.Task, Microsoft.NET.Runtime.WebAssembly.Sdk, Microsoft.Bcl.AsyncInterfaces, Microsoft.Bcl.TimeProvider, System.Collections.Immutable, System.Diagnostics.PerformanceCounter, System.IO.Hashing, System.Memory.Data, System.Numerics.Tensors, System.Runtime.Caching, Microsoft.NETCore.BrowserDebugHost.Transport, System.Composition, Microsoft.NETCore.Platforms (Version 10.0.0-preview.7.25359.101 -> 10.0.0-preview.7.25360.101)
Microsoft.Web.Xdt (Version 3.2.0-preview.25359.101 -> 3.2.0-preview.25360.101)
Microsoft.DotNet.HotReload.Agent, Microsoft.DotNet.HotReload.Agent.Data (Version 10.0.100-preview.7.25359.101 -> 10.0.100-preview.7.25360.101)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk (Version 10.0.0-beta.25359.101 -> 10.0.0-beta.25360.101)
Microsoft.Build, Microsoft.Build.Framework, Microsoft.Build.Tasks.Core, Microsoft.Build.Utilities.Core (Version 17.15.0-preview-25359-101 -> 17.15.0-preview-25360-101)
dotnet-maestro bot added 2 commits July 16, 2025 02:02
[[ commit created by automation ]]
Updated Dependencies:
dotnet-ef, Microsoft.EntityFrameworkCore.InMemory, Microsoft.EntityFrameworkCore.Relational, Microsoft.EntityFrameworkCore.Sqlite, Microsoft.EntityFrameworkCore.SqlServer, Microsoft.EntityFrameworkCore.Tools, Microsoft.EntityFrameworkCore, Microsoft.EntityFrameworkCore.Design, Microsoft.Extensions.Caching.Abstractions, Microsoft.Extensions.Caching.Memory, Microsoft.Extensions.Configuration.Abstractions, Microsoft.Extensions.Configuration.Binder, Microsoft.Extensions.Configuration.CommandLine, Microsoft.Extensions.Configuration.EnvironmentVariables, Microsoft.Extensions.Configuration.FileExtensions, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.Configuration.Json, Microsoft.Extensions.Configuration.UserSecrets, Microsoft.Extensions.Configuration.Xml, Microsoft.Extensions.Configuration, Microsoft.Extensions.DependencyInjection.Abstractions, Microsoft.Extensions.DependencyInjection, Microsoft.Extensions.Diagnostics, Microsoft.Extensions.Diagnostics.Abstractions, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Composite, Microsoft.Extensions.FileProviders.Physical, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.HostFactoryResolver.Sources, Microsoft.Extensions.Hosting.Abstractions, Microsoft.Extensions.Hosting, Microsoft.Extensions.Http, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Configuration, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.Logging.Debug, Microsoft.Extensions.Logging.EventSource, Microsoft.Extensions.Logging.EventLog, Microsoft.Extensions.Logging.TraceSource, Microsoft.Extensions.Logging, Microsoft.Extensions.Options.ConfigurationExtensions, Microsoft.Extensions.Options.DataAnnotations, Microsoft.Extensions.Options, Microsoft.Extensions.Primitives, Microsoft.Internal.Runtime.AspNetCore.Transport, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Diagnostics.EventLog, System.DirectoryServices.Protocols, System.Formats.Asn1, System.Formats.Cbor, System.IO.Pipelines, System.Net.Http.Json, System.Net.Http.WinHttpHandler, System.Net.ServerSentEvents, System.Reflection.Metadata, System.Resources.Extensions, System.Security.Cryptography.Pkcs, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encodings.Web, System.Text.Json, System.Threading.AccessControl, System.Threading.Channels, System.Threading.RateLimiting, Microsoft.Extensions.DependencyModel, Microsoft.NETCore.App.Ref, Microsoft.NET.Runtime.MonoAOTCompiler.Task, Microsoft.NET.Runtime.WebAssembly.Sdk, Microsoft.Bcl.AsyncInterfaces, Microsoft.Bcl.TimeProvider, System.Collections.Immutable, System.Diagnostics.PerformanceCounter, System.IO.Hashing, System.Memory.Data, System.Numerics.Tensors, System.Runtime.Caching, Microsoft.NETCore.BrowserDebugHost.Transport, System.Composition, Microsoft.NETCore.Platforms (Version 10.0.0-preview.7.25360.101 -> 10.0.0-preview.7.25365.101)
Microsoft.Web.Xdt (Version 3.2.0-preview.25360.101 -> 3.2.0-preview.25365.101)
Microsoft.DotNet.HotReload.Agent, Microsoft.DotNet.HotReload.Agent.Data (Version 10.0.100-preview.7.25360.101 -> 10.0.100-preview.7.25365.101)
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk (Version 10.0.0-beta.25360.101 -> 10.0.0-beta.25365.101)
Microsoft.Build, Microsoft.Build.Framework, Microsoft.Build.Tasks.Core, Microsoft.Build.Utilities.Core (Version 17.15.0-preview-25360-101 -> 17.15.0-preview-25365-101)
@akoeplinger
Copy link
Member

test failures seem to all be related to this crash at the end of the test run:

[xUnit.net 00:45:24.26] Microsoft.AspNetCore.Components.E2ETests: Catastrophic failure: System.NullReferenceException: Object reference not set to an instance of an object.
   at Microsoft.VisualStudio.TestPlatform.ObjectModel.Navigation.PortableSymbolReader.Dispose()
   at Microsoft.VisualStudio.TestPlatform.ObjectModel.DiaSession.Dispose()
   at Xunit.Runner.VisualStudio.DiaSessionWrapper.Dispose()
   at Xunit.Runner.VisualStudio.VisualStudioSourceInformationProvider.DisposeAsync()
   at Xunit.Runner.VisualStudio.VsTestRunner.RunTestsInAssembly(IRunContext runContext, IFrameworkHandle frameworkHandle, LoggerHelper logger, TestPlatformContext testPlatformContext, RunSettings runSettings, IMessageSink reporterMessageHandler, AssemblyRunInfo runInfo)

@nohwnd any idea? I don't see recent changes in PortableSymbolReader

<MicrosoftNETCoreBrowserDebugHostTransportVersion>10.0.0-preview.7.25365.101</MicrosoftNETCoreBrowserDebugHostTransportVersion>
<MicrosoftExtensionsCachingAbstractionsVersion>10.0.0-preview.7.25365.101</MicrosoftExtensionsCachingAbstractionsVersion>
<MicrosoftExtensionsCachingMemoryVersion>10.0.0-preview.7.25365.101</MicrosoftExtensionsCachingMemoryVersion>
<MicrosoftExtensionsCachingHybridVersion>10.0.0-alpha.2.24462.2</MicrosoftExtensionsCachingHybridVersion>
Copy link
Member

@akoeplinger akoeplinger Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmitche @wtgodbe this is an interesting case as a fallout from #62663.

Note that it's trying to update to alpha.2.24462.2 from the .NET 10 channel, because the package was produced in the dotnet/aspnetcore repo at the time.

But we actually want to use 9.8.0-preview.1.25358.1 from the .NET 9 channel from the dotnet/extensions repo as defined further down.

I think we could remove all 10.0 versions of this asset from the .NET 10 channel.

@nohwnd
Copy link
Member

nohwnd commented Jul 16, 2025

@nohwnd any idea? I don't see recent changes in PortableSymbolReader

Me neither. Does it reproduce on re-run? I am not even sure what version of xunit / vstest object model is used here, and it does not look like either is updated by this PR.

@Youssef1313
Copy link
Member

The failure might be a regression from xunit.runner.visualstudio. It was updated in Arcade:

dotnet/arcade@d183412...4e52620

@Youssef1313
Copy link
Member

Youssef1313 commented Jul 16, 2025

Likely regression from xunit/visualstudio.xunit@87f2892

The whole diff between the two versions involved here: xunit/visualstudio.xunit@dd36e86...bf6400f

@Youssef1313
Copy link
Member

To workaround, consider disabling source info explicitly via runsettings, or via command-line by using dotnet test -- RunConfiguration.CollectSourceInformation=false.

Note that this is not only a workaround, but also a perf improvement as calculating source information for command-line runs is redundant in most cases.

@Youssef1313
Copy link
Member

Looking more closely, I don't see why that change in xunit would cause any issues but that's the only related change here.

This was referenced Jul 16, 2025
@akoeplinger
Copy link
Member

@Youssef1313 maybe something is setting CollectSourceInformation=true and before that change xunit was ignoring it? E.g. this one is setting true, but I don't know if it is actually involved here: https://github.com/microsoft/testfx/blob/689830b314494a93b276672b70e35629d38ce639/src/Adapter/MSTestAdapter.PlatformServices/RunConfigurationSettings.cs#L34

@Youssef1313
Copy link
Member

The snippet you linked is for MSTest. That shouldn't be involved for anything xunit

@Youssef1313
Copy link
Member

Youssef1313 commented Jul 16, 2025

PR #62748 is failing with the same though exception here. So it's linked to xunit.runner.visualstudio update. Problem is I see zero opportunities for PortableSymbolReader.Dispose to throw NullReferenceException. I thought of double dispose, wrong usage of API etc, but can't see how it can throw under any case.

@nohwnd
Copy link
Member

nohwnd commented Jul 16, 2025

we also did not touch that api in vstest for a long time, and xunit have been updating regularly (17.13 used since 2 months ago), 17.12 since 8 months ago, so it is not like they are doing a big jump between the versions that were updated (bit hard to link the versions together just by looking at the repo though).

@Youssef1313
Copy link
Member

I'm suspecting a possibility of double dispose that are running concurrently causing issue with the disposal logic here.

cc @bradwilson

@akoeplinger
Copy link
Member

So according to #62749 it fails with 3.1.0 too and in main we should be using 3.0.2 so xunit/visualstudio.xunit@3.0.2...3.1.0 should be the range.

@bradwilson
Copy link

A double dispose problem that's been in place for 2 months and would affect anybody, but nobody's reported it? I suppose it's possible but the likelihood seems low-ish.

@Youssef1313
Copy link
Member

Youssef1313 commented Jul 16, 2025

@akoeplinger Would you be able to send me a crash dump please?

@bradwilson
Copy link

I don't have any double disposal protections in place in xunit.runner.visualstudio, so I'll add some and see if anything pops.

@bradwilson
Copy link

Double-Dispose guards are available in xunit.runner.visualstudio version 3.1.3-pre.2

https://xunit.net/docs/using-ci-builds

@bradwilson
Copy link

To workaround, consider disabling source info explicitly via runsettings, or via command-line by using dotnet test -- RunConfiguration.CollectSourceInformation=false

I'm curious why CollectionSourceInformation would be true for a command-line build. Shouldn't it be false by default for dotnet test and only true by default for runs inside Visual Studio?

@bradwilson
Copy link

I'm able to reproduce this here with v2 projects, but not v3 projects:

image

That would probably explain why we're not seeing many reports, as I'm guessing people don't generally upgrade to the 3.x xunit.runner.visualstudio if they're sticking with xUnit.net v2.

Also, turning off CollectSourceInformation does not appear to have any effect.

@bradwilson
Copy link

Yep, it's a double disposal. The wrapper which converts a v3 source information provider into a v2 source information provider is disposing the v3 version, whose lifetime is already owned outside. Should be an easy fix.

@bradwilson
Copy link

Working now with 3.1.3-pre.3:

image

I'll put together a 3.1.3 release and push to NuGet in a little bit.

@bradwilson
Copy link

3.1.3 is on NuGet. https://dotnet.social/@xunit/114864975508074208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework build-ops Type: Dependency Update 🔼
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants