Skip to content

Feature for setting activity tags on creation #62090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Feature for setting activity tags on creation #62090

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b3f5117
Feature for setting activity tags on creation
rkarg-blizz May 23, 2025
9fd4b51
adding unshipped public API entries
rkarg-blizz May 23, 2025
69e6a27
moving to TagList
rkarg-blizz May 23, 2025
94f7066
Less specific property type
rkarg-blizz May 23, 2025
21f6bb1
Update HostingApplicationDiagnostics.cs
rkargMsft Jun 17, 2025
b1775dd
unconditionally adding host/port tags to Activity creation
rkargMsft Jun 25, 2025
7ea8a11
correcting variable naming
rkargMsft Jun 25, 2025
ef91318
reverting HostAndPort property
rkargMsft Jun 25, 2025
7c5e970
naming
rkargMsft Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion src/Hosting/Hosting/src/Internal/HostingApplicationDiagnostics.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,26 @@ private void RecordRequestStartMetrics(HttpContext httpContext)
{
hasDiagnosticListener = false;

var tagsForCreation = new TagList();
if (_activitySource.HasListeners() && httpContext.Request.Host.HasValue)
{
var host = httpContext.Request.Host.Host;
var port = httpContext.Request.Host.Port;
tagsForCreation.Add("server.address", host);
if (port is not null)
{
tagsForCreation.Add("server.port", port);
}
else if (string.Equals("https", httpContext.Request.Scheme, StringComparison.OrdinalIgnoreCase))
{
tagsForCreation.Add("server.port", 443);
}
else if (string.Equals("http", httpContext.Request.Scheme, StringComparison.OrdinalIgnoreCase))
{
tagsForCreation.Add("server.port", 80);
}
}

var headers = httpContext.Request.Headers;
var activity = ActivityCreator.CreateFromRemote(
_activitySource,
Expand All @@ -402,7 +422,7 @@ private void RecordRequestStartMetrics(HttpContext httpContext)
},
ActivityName,
ActivityKind.Server,
tags: null,
tags: tagsForCreation,
links: null,
loggingEnabled || diagnosticListenerActivityCreationEnabled);
if (activity is null)
Expand Down
Loading