[release/2.3] Forwarded Headers Middleware: Ignore XForwardedHeaders from Unknown Proxy #61642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from Unknown Proxy
BrennanConroy
added
the
Servicing-consider
dotnet-issue-labeler
bot
added
the
area-middleware
BrennanConroy
added
Servicing-approved
|
Hi @@BrennanConroy. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #61530 to release/2.3
Forwarded Headers Middleware: Ignore XForwardedHeaders from Unknown Proxy
Description
If the
ForwardedHeadersMiddlewaremiddleware is used without usingXForwardedForthen theKnownNetworksandKnownProxieschecks are skipped.Fixes #61449
Customer Impact
Expectations for
KnownNetworksandKnownProxiessettings are not always met. If you aren't careful with configuring your app (careful meaning aware of this issue), you can end up allowing traffic you didn't intend to allow.Regression?
Risk
Runs a check that was already there but runs it in more cases.
Verification
Packaging changes reviewed?
When servicing release/2.1