Fix HttpLoggingMiddleware Request/Response bodies logging in case of stream being closed by a subsequent middleware #61490
+111
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix HttpLoggingMiddleware Request/Response bodies logging in case of stream being closed by a subsequent middleware (#61489)
Preserve buffer contents until it is consumed by the
HttpLoggingMiddleware
Description
Fixes #61489
When the subsequent middleware closes request/response stream, the
BufferingStream
callsReset
which leads to an empty body being logged.The request stream might be closed if the subsequent middleware follows the
ContentLength
header to sense the end of the stream (instead of reading it to the end).The response stream might be closed without any additional preconditions, just because the subsequent middleware decided to do so.
A real-life example of such a middleware is
CoreWCF
BasicHttpBinding
: inputStream.Close, _outputStream.Close