Globalization test updates #12377
Merged
Globalization test updates #12377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 19, 2019 12:56
We don't want to put this in one of the product assemblies because that would undo the API review xD
This lets us specify the associations between the HTML5 field types and these settings.
While it's definitly intended for `@bind` to have culture-sensitive output for most cases, we want the tests to behave consistently for all developers. So this is an attempt to use a fixed culture for all of our testing.
We used to be inconsistent between what we'd do when formatting a value based on whether or not you specified a format. This change brings us back into consistency. For a `default` DateTime/DateTimeOffset we will just call ToString on it. For a `default` nullable of these types we will return the empty string.
rynowak
force-pushed
the
rynowak/globalization-tests
branch
from
3906045 to
2b181c9
Compare
rynowak
commented
Jul 19, 2019
rynowak
commented
Jul 19, 2019
rynowak
commented
Jul 19, 2019
src/Components/test/testassets/BasicTestApp/GlobalizationBindCases.razor
Show resolved
Hide resolved
SteveSandersonMS
approved these changes
Jul 20, 2019
ghost
deleted the
mkArtakMSFT
added
the
tell-mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Globalization test updates
Fixes: #9386
Fixes: #12286