-
Notifications
You must be signed in to change notification settings - Fork 690
[CLI] Add --framework option to aspire new #9985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -197,6 +197,7 @@ private async Task<int> ApplyTemplateAsync(CallbackTemplate template, ParseResul | |
{ | ||
var name = await GetProjectNameAsync(parseResult, cancellationToken); | ||
var outputPath = await GetOutputPathAsync(parseResult, template.PathDeriver, name, cancellationToken); | ||
var framework = parseResult.GetValue<string?>("--framework"); | ||
|
||
// Some templates have additional arguments that need to be applied to the `dotnet new` command | ||
// when it is executed. This callback will get those arguments and potentially prompt for them. | ||
|
@@ -244,6 +245,7 @@ private async Task<int> ApplyTemplateAsync(CallbackTemplate template, ParseResul | |
template.Name, | ||
name, | ||
outputPath, | ||
framework, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should pass this argument through via |
||
extraArgs, | ||
options, | ||
cancellationToken); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add prompting for selecting the framework for when people execute
aspire new
without arguments. interactive is the primary interaction model foraspire new
.