[CI] Enumerate test projects at build time for PR validation #7842
Conversation
| @@ -0,0 +1,43 @@ | |||
| <Project DefaultTargets="GenerateTestProjectsJsonForGithubActions"> | |||
There was a problem hiding this comment.
I think I would much rather have this expressed in yaml and than in msbuild.
There was a problem hiding this comment.
Having it in msbuild allows us to control at the .csproj level whether to skip the tests, though that might not be a common scenario.
I was trying to do all this in yaml, but generating the json for the matrix was a pain. But I do have the code simplified now, so that json is simpler too, and we can try yaml.
There was a problem hiding this comment.
Hm keeping it in msbuild though means that we are sharing the same rules for helix, and for gh actions, which would keep that consistent.
There was a problem hiding this comment.
I hear you, but, copilot is kinda crap at writing msbuild and it's amazing at writing yaml. When I look at our csproj files wrapping shell commands its quite unmaintainable. This yaml file is long but very clean and really easy to understand. Maybe this is a fine middle ground but it feels really messy to me.
There was a problem hiding this comment.
By "shell commands" do you mean the json being emitted to the file? I should be able to get that out of this project, then it would just be evaluating all the msbuild projects to find the ones that should be built.
The alternative would be to pick up the test projects with globbing, and keeping an exclude list in the yaml.
There was a problem hiding this comment.
My bias is David's, an exclude list in the yaml sounds good. I like simple. (If we don't care about Helix)
No description provided.