[CI] Fix workflows, and run Quarantined tests every four hours #13304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add !cancelled() && !failure() condition to run_tests job so it proceeds when build_packages is skipped (requiresNugets is false) - Update results job failure check to not fail when build_packages is skipped, since that's expected behavior
radical
added
the
area-engineering-systems
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 13304Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 13304" |
Copilot finished reviewing on behalf of
radical
December 2, 2025 22:53
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the Outerloop and Quarantine test workflows by addressing a condition bug that caused test jobs to be skipped when the package build job was skipped, and adjusts the Quarantine test schedule frequency.
- Fixes the
run_testsjob condition to prevent it from being skipped whenbuild_packagesis skipped (which happens when tests don't require NuGet packages) - Updates the final results job to explicitly check individual job statuses, properly handling the case where
build_packagesbeing skipped is expected - Changes the Quarantine tests schedule from twice daily to every 4 hours for increased data collection
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/tests-quarantine.yml |
Updates cron schedule from twice daily to every 4 hours |
.github/workflows/specialized-test-runner.yml |
Fixes job conditions to handle skipped build_packages jobs correctly and makes dependency failure checks more explicit |
radical
changed the title
radical
changed the title
eerhardt
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - the main
run-testsjob was getting skipped wheneverbuild_packagesjob was skipped.Changes the frequency of the Quarantined tests workflow to every 4 hours. This is a temporary measure so we can quickly collect data on flakiness, to cover missed coverage over past few weeks.