Build aspire extension and allow acquisition from pr cli shell script #11245
Conversation
|
🚀 Dogfood this PR with: curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 11245Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 11245" |
github-actions
bot
added
the
area-engineering-systems
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for building the VS Code Aspire extension as part of the build process and enables downloading and installing the extension through the get-aspire-cli-pr.sh script. The changes support dogfooding workflows by making it easier to test extension builds from CI.
Key changes:
- Adds
--build-extensionparameter to build scripts for building the VS Code extension - Extends
get-aspire-cli-pr.shto download and install the Aspire extension from CI artifacts - Configures publishing of extension artifacts in the build pipeline
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| extension/package.json | Minor formatting cleanup for debug configuration |
| eng/scripts/get-aspire-cli-pr.sh | Adds extension download and installation functionality with new CLI options |
| eng/common/build.sh | Implements extension build functionality for Unix platforms |
| eng/common/build.ps1 | Implements extension build functionality for Windows platforms |
| eng/build.sh | Adds --build-extension parameter handling for the main build script |
| eng/build.ps1 | Adds -buildExtension parameter handling for Windows build script |
| eng/Publishing.props | Configures publishing of .vsix extension files as build artifacts |
|
these CI errors are really confusing me |
| @@ -21,10 +21,13 @@ jobs: | |||
| - name: Checkout code | |||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | |||
|
|
|||
| - name: Install VSCE tool | |||
There was a problem hiding this comment.
How much time does this add to the build?
There was a problem hiding this comment.
Looks like it adds a about a minute. It's not the long pole on the overall build (spread across acquisition and the publish operation itself). It isn't the long pole by any stretch so probably OK.
Some of the failures are because the |
adamint
force-pushed
the
dev/adamint/build-publish-aspire-extension
branch
from
c070f8d to
7c50ca5
Compare
adamint
changed the title
| } | ||
|
|
||
| # Function to install VS Code extension | ||
| install_aspire_extension() { |
There was a problem hiding this comment.
Some team members use code-insiders I think it would be good to allow people to target code insiders for specific builds.
|
This looks good overall. Good to have this happening as part of the build. |
eng/scripts/get-aspire-cli-pr.sh
Outdated
| @@ -60,6 +64,7 @@ USAGE: | |||
| --os OS Override OS detection (win, linux, linux-musl, osx) | |||
| --arch ARCH Override architecture detection (x64, x86, arm64) | |||
| --hive-only Only install NuGet packages to the hive, skip CLI download | |||
| --skip-extension-install Skip VS Code extension download and installation | |||
There was a problem hiding this comment.
super nit suggestion - Maybe --skip-extension for fewer characters?
Description
Adds a parameter to the build scripts to build the aspire extension.
Allows acquisition of the CI aspire-extension vsix from the aspire-cli-pr shell script.
Adds the artifact to
Packaging.propsso it can eventually be downloaded inget-aspire-cliscripts.@radical is there anything else necessary and does this all look right?? I want to make dogfooding easier and get to the point where we can install the extension from
get-aspire-cli.Planning on following up with changes to
get-aspire-cli.Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate